nixos-generate-config: fix for swapless kernels #49835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg test installer |
|
Success on x86_64-linux Attempted: tests.installer No partial log is available. |
|
Success on aarch64-linux Attempted: tests.installer No partial log is available. |
lheckemann
approved these changes
Nov 14, 2018
infinisil
reviewed
Nov 17, 2018
| @@ -314,14 +314,16 @@ sub findStableDevPath { | |||
|
|
|||
| # Generate the swapDevices option from the currently activated swap | |||
| # devices. | |||
| my @swaps = read_file("/proc/swaps"); | |||
| shift @swaps; | |||
| my @swaps = read_file("/proc/swaps", err_mode => 'carp'); | |||
There was a problem hiding this comment.
Because I just spent 10 minutes trying to find the docs on this:
The err_mode option has three possible values: quiet, carp, or the default, croak. In quiet mode, all errors will be silent. In carp mode, all errors will be emitted as warnings. And, in croak mode, all errors will be emitted as exceptions. Take a look at Try::Tiny or Syntax::Keyword::Try to see how to catch exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #49826
I don't actually speak Perl, but this seems about right?
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)