Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/mysql: Explicitly set datadir in my.cnf #49838

Merged
merged 1 commit into from Nov 16, 2018
Merged

nixos/mysql: Explicitly set datadir in my.cnf #49838

merged 1 commit into from Nov 16, 2018

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Nov 6, 2018

While this seems silly at first (it's already given as start parameter
to mysqld), it seems like xtrabackup needs that sometimes.
Without it, a Galera cluster cannot be run using the xtrabackup
replication method.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dasJ
nixos/mysql: Explicitly set datadir in my.cnf
c7f5457 
While this seems silly at first (it's already given as start parameter
to mysqld), it seems like xtrabackup needs that sometimes.
Without it, a Galera cluster cannot be run using the xtrabackup
replication method.
aanderse
aanderse approved these changes Nov 14, 2018
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dasJ Nice straight forward change. Seems reasonable to backport to 18.09 as well. Just need to find someone to merge.

@samueldr
Copy link
Member

@GrahamcOfBorg test mysql

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: tests.mysql

Partial log (click to expand)

error: while evaluating 'recursiveUpdate' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:415:26, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:148:28:
while evaluating 'recursiveUpdateUntil' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:384:37, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:416:5:
while evaluating 'zipAttrsWith' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:347:21, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:394:8:
while evaluating 'zipAttrsWithNames' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:332:33, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:347:27:
while evaluating anonymous function at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/lists.nix:113:41, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:347:46:
while evaluating the attribute 'mysql' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/nixos/tests/all-tests.nix:134:3:
while evaluating 'handleTest' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/nixos/tests/all-tests.nix:17:22, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/nixos/tests/all-tests.nix:134:11:
while evaluating 'discoverTests' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/nixos/tests/all-tests.nix:13:19, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/nixos/tests/all-tests.nix:18:5:
access to path '/nix/store/mb4ghk1cf1fr473na3kkhbrf1878vlpx-rbvermaa-spot' is forbidden in restricted mode

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.mysql

Partial log (click to expand)

Cannot nix-instantiate `tests.mysql' because:
error: while evaluating 'recursiveUpdate' at /var/lib/gc-of-borg/nix-test-rs-9/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-9/lib/attrsets.nix:415:26, called from /var/lib/gc-of-borg/nix-test-rs-9/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-9/lib/attrsets.nix:148:28:
while evaluating 'recursiveUpdateUntil' at /var/lib/gc-of-borg/nix-test-rs-9/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-9/lib/attrsets.nix:384:37, called from /var/lib/gc-of-borg/nix-test-rs-9/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-9/lib/attrsets.nix:416:5:
while evaluating 'zipAttrsWith' at /var/lib/gc-of-borg/nix-test-rs-9/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-9/lib/attrsets.nix:347:21, called from /var/lib/gc-of-borg/nix-test-rs-9/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-9/lib/attrsets.nix:394:8:
while evaluating 'zipAttrsWithNames' at /var/lib/gc-of-borg/nix-test-rs-9/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-9/lib/attrsets.nix:332:33, called from /var/lib/gc-of-borg/nix-test-rs-9/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-9/lib/attrsets.nix:347:27:
while evaluating the attribute 'mysql' at /var/lib/gc-of-borg/nix-test-rs-9/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-9/nixos/tests/all-tests.nix:134:3:
while evaluating 'handleTest' at /var/lib/gc-of-borg/nix-test-rs-9/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-9/nixos/tests/all-tests.nix:17:22, called from /var/lib/gc-of-borg/nix-test-rs-9/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-9/nixos/tests/all-tests.nix:134:11:
while evaluating 'discoverTests' at /var/lib/gc-of-borg/nix-test-rs-9/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-9/nixos/tests/all-tests.nix:13:19, called from /var/lib/gc-of-borg/nix-test-rs-9/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-9/nixos/tests/all-tests.nix:18:5:
access to path '/nix/store/rk4asfribs44wpanjy05si196hbx6ngj-grahamc-aarch64-community-9' is forbidden in restricted mode

@aanderse
Copy link
Member

@GrahamcOfBorg build nixosTests.mysql

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nixosTests.mysql

Partial log (click to expand)

master: exit status 1
syncing
master: running command: sync
master: exit status 0
test script finished in 15.48s
cleaning up
killing master (pid 631)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/935v3i2l5xi0a6sgrs4mxhncbzjxwcvc-vm-test-run-mysql

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nixosTests.mysql

Partial log (click to expand)

master: exit status 1
syncing
master: running command: sync
master: exit status 0
test script finished in 173.14s
cleaning up
killing master (pid 600)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/93m3mi74hfmgq6qazmygjd9y75wbmddi-vm-test-run-mysql

@aanderse
Copy link
Member

@samueldr quick and easy merge?

@samueldr samueldr merged commit 07eaaf6 into NixOS:master Nov 16, 2018
@dasJ dasJ deleted the mysql-datadir branch November 27, 2018 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dasJ @samueldr @GrahamcOfBorg @aanderse