falkon: enable qtwayland #49806
Merged
falkon: enable qtwayland #49806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbauer
reviewed
Nov 5, 2018
| @@ -21,8 +24,8 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| buildInputs = [ | |||
| libpthreadstubs libxcb libXdmcp | |||
| qtsvg qttools qtwebengine qtx11extras qtwayland | |||
There was a problem hiding this comment.
this should just be added on stdenv.isLinux
There was a problem hiding this comment.
Thanks. I changed this, but it doesn't seem to be activating on my system, despite me running NixOS on an x64 processor? Or I didn't add it correctly, but I followed the pattern I saw in other files.
colemickens
force-pushed
the
falkon-qtwayland
branch
from
7103f0f
to
c3526c7
Compare
Mic92
reviewed
Nov 6, 2018
| kwallet | ||
| qtsvg qtwebengine qtx11extras | ||
| ]; | ||
| ] ++ lib.optional stdenv.isLinux [ qtwayland ]; |
There was a problem hiding this comment.
Suggested change
| ] ++ lib.optional stdenv.isLinux [ qtwayland ]; | |
| ] ++ lib.optionals stdenv.isLinux [ qtwayland ]; |
or
Suggested change
| ] ++ lib.optional stdenv.isLinux [ qtwayland ]; | |
| ] ++ lib.optional stdenv.isLinux qtwayland; |
colemickens
force-pushed
the
falkon-qtwayland
branch
from
c3526c7
to
4d26a57
Compare
|
Thanks @matthewbauer @Mic92. Comments addressed, working as intended. |
|
@GrahamcOfBorg build falkon |
|
Success on x86_64-linux (full log) Attempted: falkon Partial log (click to expand)
|
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: falkon Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: falkon Partial log (click to expand)
|
Looks like there's no issues with and earlier |
|
@GrahamcOfBorg build falkon Hopefully, a bit fewer dependencies to build, and better luck in the |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: falkon Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: falkon Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: falkon Partial log (click to expand)
|
|
Thanks for the info and nudging the bot, @samueldr ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Enable wayland support in
falkon.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)