Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dwarf-fortress: fix most of customization options #49803

Closed
wants to merge 1 commit into from
Closed

dwarf-fortress: fix most of customization options #49803

wants to merge 1 commit into from
+2 −2

Conversation

Lassulus
Copy link
Member

@Lassulus Lassulus commented Nov 5, 2018

Motivation for this change

fix #49779

@Lassulus
dwarf-fortress: fix most of customization options

Verified

This commit was signed with the committer’s verified signature. The key has expired.
schneefux
GPG key ID: 50F2BF336737C2F0
Expired
Verified
Learn about vigilant mode
6f163b6
@Lassulus Lassulus mentioned this pull request Nov 5, 2018
Closed
@Lassulus
Copy link
Member Author

Lassulus commented Nov 5, 2018

if merged, please backport to 18.09

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: dwarf-fortress

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: dwarf-fortress

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: dwarf-fortress

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@bendlas
Copy link
Contributor

bendlas commented Nov 5, 2018

curious, that this kind of error wouldn't trigger a syntax or build error.

in any case, with this patch, both a minimally built vanilla dwarf-fortress and a dfhack with all addons build and start into their respective main menus.

bendlas pushed a commit that referenced this pull request Nov 6, 2018
@Lassulus @bendlas
dwarf-fortress: fix most of customization options

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
0c774fa 
see #49779
close #49803

(cherry picked from commit 290dd06)
@bendlas bendlas closed this in 290dd06 Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dwarf-fortress: dfhack fatal error
3 participants
@Lassulus @GrahamcOfBorg @bendlas