Do test on Python 3.7 #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Picard supports Python 3.7, so making sure plugins work on it is very useful. Heavily inspired by metabrainz#177 ;)
|
Ugh. Looks like the Travisbuntu is too ancient to have Py3.7? I'll try and look into this later. |
|
Unfortunately it won't work that easily, unless they have Python 3.7 finally available on Travis CI :) See metabrainz/picard@c0448cb for a working solution if the builds will fail EDIT: Yep, failed :( |
Ubuntu 14.04 Trusty (Travis' default distribution) doesn't contain Python 3.7 and is generally more than 4 years old and I think not supported by Picard 2.0 anyway, so moving to a 2 years never version of Ubuntu that does contain Python 3.7.
|
Instead of making an additional |
phw
approved these changes
Nov 6, 2018
zas
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picard supports Python 3.7, so making sure plugins work on it is very useful.
Heavily inspired by #177 ;)