GMC-135: Riemann fixage #49782
Closed
GMC-135: Riemann fixage #49782
+46,962
−25,702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit a16c6d8)
(cherry picked from commit bd02b33)
(cherry picked from commit 6e8da1d)
(cherry picked from commit f7a2e20)
(cherry picked from commit 9ec17c6)
(cherry picked from commit c2e269e)
(cherry picked from commit bb06b5b)
(cherry picked from commit 7d43e2a)
(cherry picked from commit 751c647)
The package is no longer maintained and includes potential security vulnerabilities (a use-after-free and several crashes) that are known and not fixed in the version present in nixpkgs. They don't look too bad judging from the trigger vectors mentioned in the changelog, but with the project going unmaintained one of them becoming a security vulnerability would likely not be noticed. (cherry picked from commit ad992cb)
(cherry picked from commit e7549b9)
(cherry picked from commit d664b8f)
(cherry picked from commit ef05e10)
(cherry picked from commit f85a4ba)
(cherry picked from commit c547c3f)
(cherry picked from commit e0c6981)
(cherry picked from commit 3b3bde4)
(cherry picked from commit 4edb318)
(cherry picked from commit 655a5fa)
(cherry picked from commit 77140a9)
(cherry picked from commit c100a45)
(cherry picked from commit 0eb3b93)
(cherry picked from commit b61dd2b)
The previous description "string" is misleading in the full options
manual pages; they are actually concatenated strings, with a specific
character.
The empty string version ("types.string") has been special-cased to
provide a better message.
(cherry picked from commit 0808c7c)
Adds macOS Mojave (10.14) support. (cherry picked from commit 42088e0)
(cherry picked from commit a01cab0) Backport of NixOS#48000
(cherry picked from commit 88e7d7b)
(cherry picked from commit 011a463)
(cherry picked from commit fed0a4e)
(cherry picked from commit 97d2779)
deepfire
requested review from
FRidh,
LnL7,
matthewbauer,
Mic92,
nbp,
peti,
ryantm,
thoughtpolice,
ttuegel and
zimbatm
as code owners
GrahamcOfBorg
added
6.topic: emacs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)