Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMC-135: Riemann fixage #49782

Closed
wants to merge 1,069 commits into from
Closed

Conversation

deepfire
Copy link
Contributor

@deepfire deepfire commented Nov 5, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

worldofpeace and others added 30 commits October 12, 2018 16:56
(cherry picked from commit bd02b33)
(cherry picked from commit 6e8da1d)
(cherry picked from commit f7a2e20)
(cherry picked from commit 9ec17c6)
(cherry picked from commit c2e269e)
(cherry picked from commit 7d43e2a)
The package is no longer maintained and includes potential security
vulnerabilities (a use-after-free and several crashes) that are known
and not fixed in the version present in nixpkgs. They don't look too bad
judging from the trigger vectors mentioned in the changelog, but with
the project going unmaintained one of them becoming a security
vulnerability would likely not be noticed.

(cherry picked from commit ad992cb)
(cherry picked from commit ef05e10)
(cherry picked from commit f85a4ba)
(cherry picked from commit c547c3f)
(cherry picked from commit e0c6981)
(cherry picked from commit 655a5fa)
(cherry picked from commit 77140a9)
The previous description "string" is misleading in the full options
manual pages; they are actually concatenated strings, with a specific
character.

The empty string version ("types.string") has been special-cased to
provide a better message.

(cherry picked from commit 0808c7c)
Adds macOS Mojave (10.14) support.

(cherry picked from commit 42088e0)
(cherry picked from commit 88e7d7b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet