Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dune: 1.5.1 -> 1.6.2 #51941

Merged
merged 1 commit into from Dec 13, 2018
Merged

dune: 1.5.1 -> 1.6.2 #51941

merged 1 commit into from Dec 13, 2018

Conversation

Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Dec 13, 2018 •
edited

Motivation for this change

Coq will soon need Dune 1.6.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Dec 13, 2018

Update:

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"

@vbgl vbgl merged commit 958a6c6 into NixOS:master Dec 13, 2018
@Zimmi48 Zimmi48 deleted the dune-1.6.2 branch April 10, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: coq 6.topic: ocaml 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zimmi48 @vbgl @GrahamcOfBorg