Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liberation fonts updates #51956

Merged
merged 4 commits into from Dec 18, 2018
Merged

liberation fonts updates #51956

merged 4 commits into from Dec 18, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Fixes #51331

I pushed fixes to the prior but the histories were too divergent.

The feedback that needed to be addressed from the last pr has been resolved.
Where we're using fetchFromGitHub and we've dropped all binary fonts.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
liberationsansnarrow_binary: remove
7086cb7
@worldofpeace
liberationsansnarrow: 1.07.3 -> 1.07.6, rename to liberation-sans-narrow
7eee031 
Upstream also moved to github
@worldofpeace
liberation_ttf: drop binary packages
f0ae2ae 
That means the following attributes are gone:
  - liberation_ttf_v1_binary
  - liberation_ttf_v2_binary

Because of this Libreoffice uses liberation source fonts

I've renamed these attributes because the binary form is gone:

  - liberation_ttf_v1_from_source -> liberation_ttf_v1
  - liberation_ttf_v2_from_source -> liberation_ttf_v2

They're aliases for these.
@worldofpeace
liberation_ttf: v1: 1.07.4 -> 1.07.5 v2: 2.00.1 -> 2.00.4
c4d8436 
Upstream moved to github. Using fetchFromGitHub.
@dtzWill
Copy link
Member

dtzWill commented Dec 16, 2018

❤️ thanks!

@worldofpeace
Copy link
Contributor Author

Great, merging in this case 🎆

@worldofpeace worldofpeace merged commit 0adf200 into NixOS:master Dec 18, 2018
@worldofpeace worldofpeace deleted the liberation-fonts/update branch December 18, 2018 15:10
@dtzWill dtzWill mentioned this pull request Mar 13, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @dtzWill @fpletz @GrahamcOfBorg