binary-cache-store: add setting to disable local narinfo caching #2575

LnL7 · 2018-12-12T18:04:46Z

This is nice for debugging since the cache can have some unintended side
effects when, eg. paths are removed but not invalidated.

$ nix path-info --store 's3://test?cache=0' /nix/store/6j01qy6rj13q5nibm4gpmlv6x7sfgim8-foo
skipping local narinfo cache for 's3://test'
querying info about '/nix/store/6j01qy6rj13q5nibm4gpmlv6x7sfgim8-foo' on 's3://test'...
downloaded 's3://nix/6j01qy6rj13q5nibm4gpmlv6x7sfgim8.narinfo' (392 bytes) in 21 ms
querying foo on s3://nix
/nix/store/6j01qy6rj13q5nibm4gpmlv6x7sfgim8-foo

This is nice for debugging since the cache can have some unintended side effects when, eg. paths are removed but not invalidated.

AmineChikhaoui · 2018-12-12T18:32:51Z

src/libstore/http-binary-cache-store.cc

@@ -23,6 +23,8 @@ class HttpBinaryCacheStore : public BinaryCacheStore

 public:

+    const Setting<bool> cache{this, true, "cache", "Whether to cache narinfo metadata for this binary cache."};


should probably move to src/libstore/binary-cache-store.hh ?

Also I guess this is useful per binary cache but it's possible to set something globally through --option narinfo-cache-{positive/negative}-ttl 0 that disables cache as well.

narinfo caching doesn't make sense for file binary caches, but I could move it

LnL7 · 2019-04-20T15:10:42Z

Guess this is not particularly useful, for debugging narinfo-cache-positive-ttl can be used.

binary-cache-store: add setting to disable local narinfo caching

24c1e44

This is nice for debugging since the cache can have some unintended side effects when, eg. paths are removed but not invalidated.

AmineChikhaoui reviewed Dec 12, 2018

View reviewed changes

LnL7 closed this Apr 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

binary-cache-store: add setting to disable local narinfo caching #2575

binary-cache-store: add setting to disable local narinfo caching #2575

LnL7 commented Dec 12, 2018 •

edited

AmineChikhaoui Dec 12, 2018

LnL7 Dec 12, 2018

LnL7 commented Apr 20, 2019

		@@ -23,6 +23,8 @@ class HttpBinaryCacheStore : public BinaryCacheStore

		public:

		const Setting<bool> cache{this, true, "cache", "Whether to cache narinfo metadata for this binary cache."};

binary-cache-store: add setting to disable local narinfo caching #2575

binary-cache-store: add setting to disable local narinfo caching #2575

Conversation

LnL7 commented Dec 12, 2018 • edited

AmineChikhaoui Dec 12, 2018

Choose a reason for hiding this comment

LnL7 Dec 12, 2018

Choose a reason for hiding this comment

LnL7 commented Apr 20, 2019

LnL7 commented Dec 12, 2018 •

edited