Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests/xmonad: fix terminal title #51922

Merged
merged 1 commit into from Dec 13, 2018
Merged

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Dec 12, 2018

Motivation for this change

bash now sets a different title. Didn't catch this when I fixed i3wm

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

bash now sets a different title.
@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 13, 2018

@GrahamcOfBorg test xmonad

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 13, 2018

@GrahamcOfBorg build nixosTests.xmonad

@c0bw3b c0bw3b merged commit 562b7a7 into NixOS:master Dec 13, 2018
@hedning hedning deleted the fix-xmonad-test branch October 15, 2019 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants