Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/{sddm,lightdm}: Fix window mananger spelling #51967

Merged
merged 2 commits into from Dec 13, 2018
Merged

nixos/{sddm,lightdm}: Fix window mananger spelling #51967

merged 2 commits into from Dec 13, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Dec 13, 2018

Motivation for this change

I was looking at trying out some tiling WM's and got confused by this error from sddm and decided to try lightdm and got the same error. And when I set that param I got an error that the param didn't exist.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu etu requested a review from infinisil as a code owner December 13, 2018 21:28
@Mic92 Mic92 merged commit c72290a into NixOS:master Dec 13, 2018
@etu etu deleted the fix-windowMananger-spelling branch December 13, 2018 21:32
@Mic92
Copy link
Member

Mic92 commented Dec 13, 2018

[detached HEAD 5c5607f] nixos/sddm: Fix spelling of option in docs
Author: Elis Hirwing elis@hirwing.se
Date: Thu Dec 13 22:25:19 2018 +0100
1 file changed, 1 insertion(+), 1 deletion(-)
g[detached HEAD 7a37ddc] nixos/lightdm: Fix spelling of option in docs
Author: Elis Hirwing elis@hirwing.se
Date: Thu Dec 13 22:26:12 2018 +0100
1 file changed, 1 insertion(+), 1 deletion(-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @Mic92 @GrahamcOfBorg