Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-extensions: init vim, github, theme-onelight #51921

Closed
wants to merge 4 commits into from

Conversation

garbas
Copy link
Member

@garbas garbas commented Dec 12, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

};
meta = with stdenv.lib; {
description = ''
Pull Request Provider for GitHub
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct description?

@garbas
Copy link
Member Author

garbas commented Dec 12, 2018

I wonder how hard would it be to write and update script. please don't merge just yet, I will try to come up with some update script.

@eadwu
Copy link
Member

eadwu commented Dec 12, 2018

The update script currently in the repository works fine in terms of updating, I usually just copy over the updated versions and hashes when I spot an update when I run it.

@Mic92
Copy link
Member

Mic92 commented Dec 13, 2018

This is what I wrote for our vim plugins: https://github.com/NixOS/nixpkgs/blob/master/pkgs/misc/vim-plugins/update.py

@aanderse
Copy link
Member

aanderse commented Aug 4, 2019

Is anyone interested in continuing with this PR?

@garbas
Copy link
Member Author

garbas commented Aug 5, 2019

@aanderse i just pushed the code where i stopped working on this. maybe it will inspire you to continue. i switched to back to neovim since coc.nvim plugin gives me everything that vscode does. i will close this PR but feel free to take my work and continue it.

@garbas garbas closed this Aug 5, 2019
@aanderse
Copy link
Member

aanderse commented Aug 5, 2019

Thanks for the update @garbas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants