installables: resolve derivation outputs #2577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When converting a drv path to an installable the buildables would
contain {"out", "/nix/store/<path>.drv"} as outputs instead of the
actual outputs from the derivation.
This makes sure the result symblinks created `nix build` point to the
outputs instead of the drv file that was built.
LnL7
commented
Dec 12, 2018
| return {{isDerivation(storePath) ? storePath : "", {{"out", storePath}}}}; | ||
| if (isDerivation(storePath)) { | ||
| std::map<std::string, Path> outputs; | ||
| auto drv = readDerivation(storePath); |
There was a problem hiding this comment.
I'm not sure this is the most optimal way to query the outputs, but it works for diverted/remote stores from what I can tell.
|
This probably has unintended side effects. I just noticed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting a drv path to an installable the buildables would
contain
{"out", "/nix/store/<path>.drv"}as outputs instead of theactual outputs from the derivation.
This makes sure the result symblinks created
nix buildpoint to theoutputs instead of the drv file that was built.