Remove unnecessary parameter in Configuration methods #2608
+14
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary repository parameter in Configuration.LoadOrCreateConfiguration()
Remove unnecessary passing of path in SaveConfiguration()
|
As I wrote this PR I was wondering if SaveConfiguration() shouldn't be private instead of public, this would force Save() to be called from outside, which I understood is the goal of having this separate function. |
|
My rule of thumb: If you can make something private without breaking anything, do it. |
|
That's a great rule of thumb :P |
Make SaveConfiguration() and LoadConfiguration() privat. This needed to change two Tests.
|
Okay, made it private, also |
|
That build fail was not my fault! |
|
Build fail? What build fail? 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaultRepo
Configuration.LoadOrCreateConfiguration()gets passed adefaultRepoparameter.This is a relic of the early days of CKAN it seems, when the repositories were saved in the GUI configuration, but this got moved to the registry in 536637f.
Since then the parameter sits there unused.
path
Also
SaveConfiguration()gets passed apathparameter, which is redundant since there is a specific path variable in theConfigurationclass. It's a bit dangerous too, because it could lead to a difference between the real save path and the one set in the configuration.Now SaveConfiguration() takes the value out of the according object of Configuration, which happened in
Save()before.Add
SpaceAfterMethodCallNameto code formatting guidelineI added
$2.SpaceAfterMethodCallName = Falseto the solution file, because MonoDevelop always inserted a space between method calls an round brackets.Don't know if Visual Studio is okay with this, but I think in the worst case VS auto-removes the line again.
I encountered a strange Github display bug with the indentation in CKAN.sln, hence the 2 additional commits.