Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acl: 2.2.52 -> 2.2.53 #51963

Merged
merged 1 commit into from Dec 14, 2018
Merged

acl: 2.2.52 -> 2.2.53 #51963

merged 1 commit into from Dec 14, 2018

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Dec 13, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vaibhavsagar vaibhavsagar mentioned this pull request Dec 13, 2018
Merged
10 tasks
@Mic92
Copy link
Member

Mic92 commented Dec 13, 2018

@GrahamcOfBorg build acl

@Mic92
Copy link
Member

Mic92 commented Dec 13, 2018

Should go to staging.

@vaibhavsagar vaibhavsagar changed the base branch from master to staging December 13, 2018 22:18
@vaibhavsagar
Copy link
Member Author

Sure, updated.

@matthewbauer matthewbauer merged commit 60135e9 into NixOS:staging Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vaibhavsagar @Mic92 @matthewbauer @GrahamcOfBorg