Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makeStaticBinaries: add a static glibc when performing a mkDerivation #51966

Merged
merged 1 commit into from Dec 15, 2018
Merged

makeStaticBinaries: add a static glibc when performing a mkDerivation #51966

merged 1 commit into from Dec 15, 2018

Conversation

Twey
Copy link
Contributor

@Twey Twey commented Dec 13, 2018 •
edited

Motivation for this change

Make gcc/clang work out of the box to build static binaries in a stdenv built using makeStaticBinaries.
As mentioned in #51958.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Twey Twey mentioned this pull request Dec 13, 2018
Closed
@matthewbauer
Copy link
Member

Looks okay- but it should be conditional on stdenv.hostPlatform.libc == glibc.

I had read that some things in glibc dont work when statically linked. Musl appears to have much better support.

@Twey
Copy link
Contributor Author

Twey commented Dec 14, 2018

Done, added the check.

Yes, there are a couple of functions in glibc that can't be used statically and require a runtime glibc to be available. musl is fine but I think that's already adequately handled by pkgsMusl — with the check, I think makeStaticBinaries should just work on a musl-based stdenv.

@matthewbauer matthewbauer merged commit ca00533 into NixOS:master Dec 15, 2018
@matthewbauer matthewbauer mentioned this pull request Dec 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Twey @matthewbauer @GrahamcOfBorg