Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm 7: Allow for specifying an arbitrary list of backends to build #51930

Merged
merged 1 commit into from Dec 13, 2018
Merged

llvm 7: Allow for specifying an arbitrary list of backends to build #51930

merged 1 commit into from Dec 13, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

This common.nix is me hoping other things will also be factored out of the LLVM derivations.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Dec 13, 2018
View reviewed changes
pkgs/development/compilers/llvm/7/llvm.nix
@@ -13,7 +13,8 @@
, debugVersion ? false
, enableManpages ? false
, enableSharedLibraries ? true
, enableWasm ? true
, targets ? [ stdenv.hostPlatform stdenv.targetPlatform ]
, enableWasm ? true # TODO fold this into `targets` somehow
Copy link
Member

@Mic92 Mic92 Dec 13, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we maybe it remove flag right for now and just enable it by default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh I'm fine with how it is now. If anything, this TODO is really for later LLVMs when WASM becomes a stable backend.

@Mic92
Copy link
Member

Mic92 commented Dec 13, 2018 •
edited

I fixed cross-compilation of llvm_6 and the build != host build for llvm_7 in this branch: https://github.com/Mic92/nixpkgs/commits/cross-llvm
you could cherry-pick/rebase the commits in question.

@Ericson2314
Copy link
Member Author

@Mic92 6 would make this a bigger rebuild?

@Mic92
Copy link
Member

Mic92 commented Dec 13, 2018

True, we can keep as it is. And I add my stuff on top.

@Mic92 Mic92 merged commit 29f59a1 into NixOS:staging Dec 13, 2018
@Ericson2314
Copy link
Member Author

Thanks for taking the rebase hot potato :).

@Ericson2314 Ericson2314 deleted the llvm-targets branch December 14, 2018 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@dtzWill dtzWill Awaiting requested review from dtzWill

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @Mic92 @GrahamcOfBorg