Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.manhole: init at 1.5.0 #51929

Merged
merged 2 commits into from Dec 13, 2018
Merged

pythonPackages.manhole: init at 1.5.0 #51929

merged 2 commits into from Dec 13, 2018

Conversation

ivan
Copy link
Member

@ivan ivan commented Dec 13, 2018 •
edited

Motivation for this change

manhole is generally useful for connecting to and debugging long-running Python programs.

This dependency will be used by an upcoming PR that adds grab-site.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I tested pythonPackages.manhole and python37Packages.manhole on NixOS.

@ivan ivan requested a review from FRidh as a code owner December 13, 2018 06:33
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.manhole python3.pkgs.manhole

@dotlambda
Copy link
Member

Seems like there is a problem on Darwin: https://github.com/NixOS/nixpkgs/pull/51929/checks?check_run_id=40720694

@ivan
Copy link
Member Author

ivan commented Dec 13, 2018

Thanks for the review!

I can't reproduce the /tmp/manhole-socket removal failure on my macOS 10.13 machine, but it looks like I need to disable the tests anyway: another test fails, suggesting upstream doesn't run them on macOS.

Updated with tests disabled on Darwin.

@ivan
Copy link
Member Author

ivan commented Dec 13, 2018

I changed !stdenv.isDarwin to stdenv.isLinux. Should be done now.

@rasendubi
Copy link
Member

@GrahamcOfBorg build python27Packages.manhole python37Packages.manhole

@rasendubi rasendubi merged commit bb14e3b into NixOS:master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ivan @dotlambda @rasendubi @GrahamcOfBorg