Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos-artwork: make wallpapers available to KDE #51926

Merged
merged 1 commit into from Dec 15, 2018
Merged

nixos-artwork: make wallpapers available to KDE #51926

merged 1 commit into from Dec 15, 2018

Conversation

peterhoeg
Copy link
Member

Motivation for this change

We have some nice and clean wallpapers in https://github.com/NixOS/nixos-artwork - this PR makes them available to KDE when you right-click and choose "Configure Desktop".

If they aren't installed, they're not available either so the closure size impact is 0.

I haven't run the plasma tests yet but it works here.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/nixos-screenshot-thread/1381/17

@peterhoeg
Copy link
Member Author

@GrahamcOfBorg test plasma

@peterhoeg
Copy link
Member Author

@GrahamcOfBorg test plasma5

@zimbatm zimbatm merged commit 68baf6b into NixOS:master Dec 15, 2018
@peterhoeg peterhoeg deleted the f/wallpapers branch December 31, 2018 08:38
@peterhoeg peterhoeg restored the f/wallpapers branch January 2, 2019 01:59
@peterhoeg peterhoeg deleted the f/wallpapers branch November 5, 2019 13:36
@peterhoeg peterhoeg restored the f/wallpapers branch November 6, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@peterhoeg @nixos-discourse @matthewbauer @zimbatm @GrahamcOfBorg