Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.lmdb: enable tests #51931

Merged
merged 1 commit into from Dec 13, 2018
Merged

pythonPackages.lmdb: enable tests #51931

merged 1 commit into from Dec 13, 2018

Conversation

ivan
Copy link
Member

@ivan ivan commented Dec 13, 2018 •
edited

Motivation for this change

I noticed that the pythonPackages.lmdb tests were unnecessarily disabled for Python 3. I confirmed that the tests for python37Packages.lmdb were failing with the error described, and that they no longer fail (on Linux, at least.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ivan ivan requested a review from FRidh as a code owner December 13, 2018 07:10
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.lmdb python3.pkgs.lmdb

@dotlambda dotlambda merged commit f1b814a into NixOS:master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivan @dotlambda @GrahamcOfBorg