New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tree-wide: nixos: /var/run -> /run #51918
Conversation
I'm not sure the individual commits with all the same commit message are usefully separate? May be good to squash them all together, or make their commit messages more specific about what they're doing. |
9ede0bd
to
d450ac8
Compare
nixos/modules/programs/zsh/zsh.nix
Outdated
@@ -203,7 +203,7 @@ in | |||
|
|||
environment.shells = | |||
[ "/run/current-system/sw/bin/zsh" | |||
"/var/run/current-system/sw/bin/zsh" | |||
"/run/current-system/sw/bin/zsh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"/run/current-system/sw/bin/zsh" |
What needs to be done to get this merged? If doing this tree-wide is making the decision harder, I can split things up in separate PRs as well. For instance, I can do |
f813f85
to
99bebf3
Compare
Thanks a lot @globin for the review. I reverted the changes that you mentioned. That made me realize there are a number of changes in here that are just wrong or edge cases. I went through the changes again, removed anything that seemed fishy and committed them separately. Let me know whether this makes more sense. Also, it is good to note here that I have tried this for my local machine with nixos-rebuild, but I have not tried any of the modules individually. |
That needs to go to staging. |
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/solved-add-var-run-directory/1701/3 |
80f40fb
to
4c1af9b
Compare
@oxij Thanks a lot of the feedback! I've applied the changes (with your script, thanks!) and split the package-related commits off to a separate PR: #58222. That PR is based on latest I split the wpa_supplicant and the asterisk commits in 2 (a nixos and a pkgs commit). The pkgs commit of those were also moved to #58222. It should still be compatible if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge in a few days if no other issues are brought up.
@globin merging would be awesome! :D |
Motivation for this change
Fixes #51800
Continuation of #47856
/var/run
is deprecated intmpfiles.d
and/run
should be used. Currently this produces a warning every timenixos-rebuild switch
runs for each service that usestmpfiles.d
with an entry for/var/run
.This PR changes
/var/run
instances into/run
across nixpkgs.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)