Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/kubernetes: fix import path of default nixpkgs #51938

Merged
merged 1 commit into from Dec 13, 2018
Merged

nixos/kubernetes: fix import path of default nixpkgs #51938

merged 1 commit into from Dec 13, 2018

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Dec 13, 2018

Motivation for this change

Fix the kubernetes nixos tests

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@johanot
Copy link
Contributor Author

johanot commented Dec 13, 2018

cc @srhb

@srhb
Copy link
Contributor

srhb commented Dec 13, 2018

Tested locally, looks good. Waiting for eval to complete. :)

@srhb srhb merged commit 7a57774 into NixOS:master Dec 13, 2018
@johanot johanot deleted the nixos-kubernetes-test-fix branch December 13, 2018 12:11
@infinisil infinisil mentioned this pull request Dec 30, 2018
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johanot @srhb @GrahamcOfBorg