Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heptio-ark: 0.9.6 -> 0.10.0 #50597

Merged
merged 1 commit into from Feb 24, 2019
Merged

heptio-ark: 0.9.6 -> 0.10.0 #50597

merged 1 commit into from Feb 24, 2019

Conversation

mbode
Copy link
Contributor

@mbode mbode commented Nov 18, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 18, 2018

Heavy changelog:

Ark version 0.10.0 introduces a number of breaking changes. Before you upgrade to version 0.10.0, make sure to read the documentation on upgrading.

  • Switch from Config to BackupStorageLocation and VolumeSnapshotLocation CRDs, and new server flags
  • Reorganization of data in object storage

The rest of the release notes: https://github.com/heptio/ark/releases/tag/v0.10.0

Don't really know how to deal with this, but it should probably be mentioned in the release note for 19.03 because it will be a breaking change from 18.09 (shipping heptio-ark v0.9)

@mbode
Copy link
Contributor Author

mbode commented Nov 26, 2018

@c0bw3b thanks for noticing! I am not so sure about the semantics of the release notes. If I am not mistaken, heptio-ark is only available as a CLI in nixpkgs (no NixOS service). The breaking changes pertain to the server-side components (living in a Kubernetes cluster) afaict. Should I still mention it in nixos/doc/manual/release-notes/rl-1903.xml?

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 26, 2018

Ok you probably know better than me since you're the maintainer. True there is no service module service for this but people might rely on nixpkgs outside of NixOS too. It seems it's the same binary providing ark server [options] too, no?
But I guess people using this know what they're doing.

@offlinehacker
Copy link
Contributor

I think everyone is running ark as kubernetes controller from docker image for now, so it's safe to merge.

@ryantm
Copy link
Member

ryantm commented Feb 24, 2019

@GrahamcOfBorg build heptio-ark

@ryantm
Copy link
Member

ryantm commented Feb 24, 2019

heptio-ark was already failing on Darwin before this patch

@ryantm ryantm merged commit c18c18d into NixOS:master Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants