Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flink: 1.6.1 -> 1.6.2 #50592

Merged
merged 2 commits into from Nov 18, 2018
Merged

flink: 1.6.1 -> 1.6.2 #50592

merged 2 commits into from Nov 18, 2018

Conversation

mbode
Copy link
Contributor

@mbode mbode commented Nov 18, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 18, 2018

¤ Changelog for 1.6.2:
https://flink.apache.org/news/2018/10/29/release-1.6.2.html

[FLINK-10363] - S3 FileSystem factory prints secrets into logs

Only affecting v1.6.1 which is not part of a release so no backport needed.

¤ Changelog for 1.5.5:
https://flink.apache.org/news/2018/10/29/release-1.5.5.html

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 18, 2018

@GrahamcOfBorg build flink flink_1_5

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: flink, flink_1_5

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: flink, flink_1_5

Partial log (click to expand)

/nix/store/y2zqgclp8p5rxp1jy91az5mwzq6vld3m-flink-1.6.2/opt/flink/bin/taskmanager.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/y2zqgclp8p5rxp1jy91az5mwzq6vld3m-flink-1.6.2/opt/flink/bin/flink: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/y2zqgclp8p5rxp1jy91az5mwzq6vld3m-flink-1.6.2/opt/flink/bin/jobmanager.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/y2zqgclp8p5rxp1jy91az5mwzq6vld3m-flink-1.6.2/opt/flink/bin/start-zookeeper-quorum.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/y2zqgclp8p5rxp1jy91az5mwzq6vld3m-flink-1.6.2/opt/flink/bin/yarn-session.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/y2zqgclp8p5rxp1jy91az5mwzq6vld3m-flink-1.6.2/opt/flink/bin/standalone-job.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/y2zqgclp8p5rxp1jy91az5mwzq6vld3m-flink-1.6.2/opt/flink/bin/flink-console.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/y2zqgclp8p5rxp1jy91az5mwzq6vld3m-flink-1.6.2...
/nix/store/y2zqgclp8p5rxp1jy91az5mwzq6vld3m-flink-1.6.2
/nix/store/s2mnx9gjh1d5xhf0lvjz3pfbfn9c3b8m-flink-1.5.5

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 18, 2018

@mbode for next updates, please provide a link to changelogs (at least in the PR description).
Especially if you see a security-related fix that should warrant a backport.

@c0bw3b c0bw3b merged commit e5b6438 into NixOS:master Nov 18, 2018
@mbode mbode deleted the flink_1_6_2 branch November 26, 2018 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mbode @c0bw3b @GrahamcOfBorg