Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-rotate-key: 1.0.3 -> 1.0.4 #50594

Merged
merged 1 commit into from Nov 18, 2018
Merged

aws-rotate-key: 1.0.3 -> 1.0.4 #50594

merged 1 commit into from Nov 18, 2018

Conversation

mbode
Copy link
Contributor

@mbode mbode commented Nov 18, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 18, 2018

@GrahamcOfBorg build aws-rotate-key

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: aws-rotate-key

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/iyg5fhsgiadi8bp5f1dmmcwwv2p3cp10-aws-rotate-key-1.0.4-bin
shrinking /nix/store/iyg5fhsgiadi8bp5f1dmmcwwv2p3cp10-aws-rotate-key-1.0.4-bin/bin/aws-rotate-key
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/iyg5fhsgiadi8bp5f1dmmcwwv2p3cp10-aws-rotate-key-1.0.4-bin/bin
patching script interpreter paths in /nix/store/iyg5fhsgiadi8bp5f1dmmcwwv2p3cp10-aws-rotate-key-1.0.4-bin
checking for references to /build in /nix/store/iyg5fhsgiadi8bp5f1dmmcwwv2p3cp10-aws-rotate-key-1.0.4-bin...
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
/nix/store/iyg5fhsgiadi8bp5f1dmmcwwv2p3cp10-aws-rotate-key-1.0.4-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: aws-rotate-key

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7lmc2wjw3fkbwgk68b4swdr0g8xrz9df-aws-rotate-key-1.0.4-bin
shrinking /nix/store/7lmc2wjw3fkbwgk68b4swdr0g8xrz9df-aws-rotate-key-1.0.4-bin/bin/aws-rotate-key
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7lmc2wjw3fkbwgk68b4swdr0g8xrz9df-aws-rotate-key-1.0.4-bin/bin
patching script interpreter paths in /nix/store/7lmc2wjw3fkbwgk68b4swdr0g8xrz9df-aws-rotate-key-1.0.4-bin
checking for references to /build in /nix/store/7lmc2wjw3fkbwgk68b4swdr0g8xrz9df-aws-rotate-key-1.0.4-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/7lmc2wjw3fkbwgk68b4swdr0g8xrz9df-aws-rotate-key-1.0.4-bin

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 18, 2018

Changelog:

Add cleanup flag to delete deactivated key if specified

@c0bw3b c0bw3b merged commit 8892ed5 into NixOS:master Nov 18, 2018
@mbode mbode deleted the aws-rotate-key_1_0_4 branch November 26, 2018 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mbode @c0bw3b @GrahamcOfBorg