Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.magic-wormhole: 0.10.5 -> 0.11.2 #50634

Merged
merged 2 commits into from Nov 20, 2018
Merged

pythonPackages.magic-wormhole: 0.10.5 -> 0.11.2 #50634

merged 2 commits into from Nov 20, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Nov 18, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner November 18, 2018 22:11
worldofpeace
worldofpeace suggested changes Nov 18, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The txaio update is already in staging-next

@marsam
Copy link
Contributor Author

marsam commented Nov 19, 2018

@worldofpeace do I change the base branch to staging or wait until staging is merged into master?

@marsam marsam force-pushed the feature/update-python-magic-wormhole branch from 3e03c20 to 5f1c0f0 Compare November 19, 2018 00:41
@worldofpeace
Copy link
Contributor

@worldofpeace do I change the base branch to staging or wait until staging is merged into master?

Currently magic-wormhole is broken on master because a failure in the dependency chain.
That fix is going to be delivered to master from staging-next. (txaio update)

So merging this without your txaio bump is good for master.

@marsam marsam force-pushed the feature/update-python-magic-wormhole branch from 5f1c0f0 to 8e16dc0 Compare November 19, 2018 02:58
@marsam
Copy link
Contributor Author

marsam commented Nov 19, 2018

okay I've removed the txaio bump

@worldofpeace
Copy link
Contributor

worldofpeace commented Nov 19, 2018 •
edited

@GrahamcOfBorg build pythonPackages.magic-wormhole python3Packages.magic-wormhole

Just checking, should still be broken 😄

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: pythonPackages.magic-wormhole, python3Packages.magic-wormhole

Partial log (click to expand)

cannot build derivation '/nix/store/0f4i50l22l3ljq8yp777xpnaa3vnzyi2-python2.7-magic-wormhole-mailbox-server-0.3.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/j52zw1nywrbmgs29mfnq9zlazfvff76r-python2.7-magic-wormhole-0.11.2.drv': 2 dependencies couldn't be built
Processing ./autobahn-18.8.2-py2.py3-none-any.whl
Collecting txaio>=18.8.1 (from autobahn==18.8.2)
  Could not find a version that satisfies the requirement txaio>=18.8.1 (from autobahn==18.8.2) (from versions: )
No matching distribution found for txaio>=18.8.1 (from autobahn==18.8.2)
builder for '/nix/store/2bg03iamlbx34p92qrbbw732vr2bw1vd-python3.6-autobahn-18.8.2.drv' failed with exit code 1
cannot build derivation '/nix/store/4pifabnvb5zkmglh7ks9rrjichiiafhk-python3.6-magic-wormhole-mailbox-server-0.3.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/j46v2xls68bw1a0vnk0l8vvgc1s4z79s-python3.6-magic-wormhole-0.11.2.drv': 2 dependencies couldn't be built
error: build of '/nix/store/j46v2xls68bw1a0vnk0l8vvgc1s4z79s-python3.6-magic-wormhole-0.11.2.drv', '/nix/store/j52zw1nywrbmgs29mfnq9zlazfvff76r-python2.7-magic-wormhole-0.11.2.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: pythonPackages.magic-wormhole, python3Packages.magic-wormhole

Partial log (click to expand)

cannot build derivation '/nix/store/7grpr796jyqnbmhblyrrsz1z680kr466-python2.7-magic-wormhole-mailbox-server-0.3.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ylz9753axvqpa8lhlbni7i1kjsvk29q0-python2.7-magic-wormhole-0.11.2.drv': 2 dependencies couldn't be built
Processing ./autobahn-18.8.2-py2.py3-none-any.whl
Collecting txaio>=18.8.1 (from autobahn==18.8.2)
  Could not find a version that satisfies the requirement txaio>=18.8.1 (from autobahn==18.8.2) (from versions: )
No matching distribution found for txaio>=18.8.1 (from autobahn==18.8.2)
builder for '/nix/store/icsf7hsxqwlnrix1b87m2nl9gdv5aj89-python3.6-autobahn-18.8.2.drv' failed with exit code 1
cannot build derivation '/nix/store/0sdii6lpdp0asij82qbr3xm1gpb3r4lh-python3.6-magic-wormhole-mailbox-server-0.3.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/2w9mzq24jm91ya633lc4pvl55ly8vrby-python3.6-magic-wormhole-0.11.2.drv': 2 dependencies couldn't be built
error: build of '/nix/store/2w9mzq24jm91ya633lc4pvl55ly8vrby-python3.6-magic-wormhole-0.11.2.drv', '/nix/store/ylz9753axvqpa8lhlbni7i1kjsvk29q0-python2.7-magic-wormhole-0.11.2.drv' failed

@marsam marsam force-pushed the feature/update-python-magic-wormhole branch from 8e16dc0 to 34b57cd Compare November 19, 2018 03:39
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: pythonPackages.magic-wormhole, python3Packages.magic-wormhole

Partial log (click to expand)

cannot build derivation '/nix/store/0f4i50l22l3ljq8yp777xpnaa3vnzyi2-python2.7-magic-wormhole-mailbox-server-0.3.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/j52zw1nywrbmgs29mfnq9zlazfvff76r-python2.7-magic-wormhole-0.11.2.drv': 2 dependencies couldn't be built
Processing ./autobahn-18.8.2-py2.py3-none-any.whl
Collecting txaio>=18.8.1 (from autobahn==18.8.2)
  Could not find a version that satisfies the requirement txaio>=18.8.1 (from autobahn==18.8.2) (from versions: )
No matching distribution found for txaio>=18.8.1 (from autobahn==18.8.2)
builder for '/nix/store/2bg03iamlbx34p92qrbbw732vr2bw1vd-python3.6-autobahn-18.8.2.drv' failed with exit code 1
cannot build derivation '/nix/store/4pifabnvb5zkmglh7ks9rrjichiiafhk-python3.6-magic-wormhole-mailbox-server-0.3.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/j46v2xls68bw1a0vnk0l8vvgc1s4z79s-python3.6-magic-wormhole-0.11.2.drv': 2 dependencies couldn't be built
error: build of '/nix/store/j46v2xls68bw1a0vnk0l8vvgc1s4z79s-python3.6-magic-wormhole-0.11.2.drv', '/nix/store/j52zw1nywrbmgs29mfnq9zlazfvff76r-python2.7-magic-wormhole-0.11.2.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: pythonPackages.magic-wormhole, python3Packages.magic-wormhole

Partial log (click to expand)

installing
/build/autobahn-18.8.2/dist /build/autobahn-18.8.2
Processing ./autobahn-18.8.2-py2.py3-none-any.whl
Collecting txaio>=18.8.1 (from autobahn==18.8.2)
  Could not find a version that satisfies the requirement txaio>=18.8.1 (from autobahn==18.8.2) (from versions: )
No matching distribution found for txaio>=18.8.1 (from autobahn==18.8.2)
builder for '/nix/store/icsf7hsxqwlnrix1b87m2nl9gdv5aj89-python3.6-autobahn-18.8.2.drv' failed with exit code 1
cannot build derivation '/nix/store/0sdii6lpdp0asij82qbr3xm1gpb3r4lh-python3.6-magic-wormhole-mailbox-server-0.3.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/2w9mzq24jm91ya633lc4pvl55ly8vrby-python3.6-magic-wormhole-0.11.2.drv': 2 dependencies couldn't be built
error: build of '/nix/store/2w9mzq24jm91ya633lc4pvl55ly8vrby-python3.6-magic-wormhole-0.11.2.drv', '/nix/store/ylz9753axvqpa8lhlbni7i1kjsvk29q0-python2.7-magic-wormhole-0.11.2.drv' failed

@marsam marsam force-pushed the feature/update-python-magic-wormhole branch from 34b57cd to 34c15cc Compare November 20, 2018 05:31
@worldofpeace
Copy link
Contributor

I glanced at the tests and they seem to only want networking with loopback, which is the only networking allowed within a sandboxed build. (with yourself)

cc @Mic92

@marsam marsam force-pushed the feature/update-python-magic-wormhole branch from 34c15cc to 007d186 Compare November 20, 2018 17:07
@marsam
Copy link
Contributor Author

marsam commented Nov 20, 2018

Reading a few threads, seems to be a problem with sandbox builds on darwin, even the darwin builders don't run with sandboxing enabled anymore. Tested on darwin (without sandbox) and Linux (with sandbox).
Rebased and I believe is ready to be merged.

@worldofpeace
Copy link
Contributor

How convenient that this finally hit also #49742.

I see you rebased with that so I can actually check if this builds here FTR.

@GrahamcOfBorg build pythonPackages.magic-wormhole python3Packages.magic-wormhole

Other than that I think 6113960 could be fixup'd into 007d186.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.magic-wormhole, python3Packages.magic-wormhole

Partial log (click to expand)

test_dict_to_bytes ... ok
test_hexstr_to_bytes (wormhole.test.test_util.Utils)
test_hexstr_to_bytes ... ok
test_to_bytes (wormhole.test.test_util.Utils)
test_to_bytes ... ok

----------------------------------------------------------------------
Ran 318 tests in 44.749s

OK

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.magic-wormhole, python3Packages.magic-wormhole

Partial log (click to expand)

test_eventually ... ok
test_flush (wormhole.test.test_eventual.Eventual)
test_flush ... ok

----------------------------------------------------------------------
Ran 318 tests in 31.291s

OK
/nix/store/pmchc6qbbfvsjqrnav1g45mkpn85zcpl-python2.7-magic-wormhole-0.11.2
/nix/store/f6rdq4sawb50w7xnv2mmmafr54zkwcpg-python3.7-magic-wormhole-0.11.2

@marsam marsam force-pushed the feature/update-python-magic-wormhole branch from 007d186 to a92b26c Compare November 20, 2018 20:41
@marsam
Copy link
Contributor Author

marsam commented Nov 20, 2018

Other than that I think 6113960 could be fixup'd into 007d186.

done

worldofpeace
worldofpeace approved these changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested execution and everything still works 👍

cc @c0bw3b

@c0bw3b c0bw3b merged commit f6e03ec into NixOS:master Nov 20, 2018
@marsam marsam deleted the feature/update-python-magic-wormhole branch November 20, 2018 21:13
@worldofpeace
Copy link
Contributor

@marsam
Thank you for your contribution and co-operation ❇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marsam @worldofpeace @GrahamcOfBorg @c0bw3b