Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

live555: 2018.02.28 -> 2018.10.17 #50612

Merged
merged 2 commits into from Nov 18, 2018
Merged

live555: 2018.02.28 -> 2018.10.17 #50612

merged 2 commits into from Nov 18, 2018

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 18, 2018 •
edited

Motivation for this change

#48825 (fix for CVE-2018-4013) reworked to :

  • explicitly mark live555 broken on aarch64
  • remove live555 in vlc only for aarch64 platform but not on other x64 unixes

I rebuilt vlc successfully on nixos with these changes.

/cc @peterhoeg @timokau @oxij

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

This was referenced Nov 18, 2018
Closed
Merged
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: live555

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: live555

Partial log (click to expand)

/nix/store/9q3054sam63vmv65jk2y0q2f67sffhzk-live555-2018.10.17

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 18, 2018

@GrahamcOfBorg build vlc

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: vlc

Partial log (click to expand)

/nix/store/rydhnc4x5p7gmzsnxnnyvzawsy9prlz5-vlc-3.0.4/bin/nvlc: interpreter directive changed from " /bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/rydhnc4x5p7gmzsnxnnyvzawsy9prlz5-vlc-3.0.4/bin/qvlc: interpreter directive changed from " /bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/rydhnc4x5p7gmzsnxnnyvzawsy9prlz5-vlc-3.0.4/bin/rvlc: interpreter directive changed from " /bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/rydhnc4x5p7gmzsnxnnyvzawsy9prlz5-vlc-3.0.4/bin/cvlc: interpreter directive changed from " /bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/rydhnc4x5p7gmzsnxnnyvzawsy9prlz5-vlc-3.0.4/share/vlc/utils/video-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/rydhnc4x5p7gmzsnxnnyvzawsy9prlz5-vlc-3.0.4/share/vlc/utils/audio-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/rydhnc4x5p7gmzsnxnnyvzawsy9prlz5-vlc-3.0.4/share/vlc/utils/gnome-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/rydhnc4x5p7gmzsnxnnyvzawsy9prlz5-vlc-3.0.4...
postPatchMkspecs
/nix/store/rydhnc4x5p7gmzsnxnnyvzawsy9prlz5-vlc-3.0.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vlc

Partial log (click to expand)

/nix/store/l4h7sqblghs5nnb4aa7jh6mip20p1rp4-vlc-3.0.4/share/vlc/utils/audio-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/l4h7sqblghs5nnb4aa7jh6mip20p1rp4-vlc-3.0.4/share/vlc/utils/gnome-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/l4h7sqblghs5nnb4aa7jh6mip20p1rp4-vlc-3.0.4/share/vlc/utils/video-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/l4h7sqblghs5nnb4aa7jh6mip20p1rp4-vlc-3.0.4/bin/nvlc: interpreter directive changed from " /bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/l4h7sqblghs5nnb4aa7jh6mip20p1rp4-vlc-3.0.4/bin/cvlc: interpreter directive changed from " /bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/l4h7sqblghs5nnb4aa7jh6mip20p1rp4-vlc-3.0.4/bin/rvlc: interpreter directive changed from " /bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/l4h7sqblghs5nnb4aa7jh6mip20p1rp4-vlc-3.0.4/bin/qvlc: interpreter directive changed from " /bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/l4h7sqblghs5nnb4aa7jh6mip20p1rp4-vlc-3.0.4...
postPatchMkspecs
/nix/store/l4h7sqblghs5nnb4aa7jh6mip20p1rp4-vlc-3.0.4

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 18, 2018

On aarch64:

checking for live555... no
configure: WARNING: No package 'live555' found.
checking for live555 version 1324598400 or later... no
configure: WARNING: live555 is missing or its installed version is too old:
Version 2011.12.23 or later is required to proceed.
You can get an updated one from http://www.live555.com/liveMedia .
checking for libdc1394-2 >= 2.1.0... yes

On x64-linux (same behaviour as previous Hydra builds):

checking for live555... no
configure: WARNING: No package 'live555' found.
checking for live555 version 1324598400 or later... yes
checking for main in -lliveMedia_pic... no
checking for main in -lliveMedia... yes
checking for libdc1394-2 >= 2.1.0... yes

@c0bw3b c0bw3b merged commit 0a870bf into NixOS:master Nov 18, 2018
@c0bw3b c0bw3b deleted the pkg/live555 branch December 2, 2018 15:20
@c0bw3b c0bw3b mentioned this pull request Dec 2, 2018
Merged
10 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-to-make-rpi4-aarch64-run-vlc-with-rtsp/14837/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@c0bw3b @GrahamcOfBorg @nixos-discourse @timokau @peterhoeg