Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cadence: fix wrong wrappings #50610

Merged
merged 4 commits into from
Nov 25, 2018
Merged

cadence: fix wrong wrappings #50610

merged 4 commits into from
Nov 25, 2018
+48 −32

Conversation

Melkor333
Copy link
Contributor

Motivation for this change

This fixes #48790

Some moduls of the Packages were automatically wrapped, but the problem is that not all of them need to be wrapped and there are some name mismatches. E.g. one Package is called cadence-logs in the binaries but logs.py in the shared folder (instead of cadence-logs.py). also - in the bin folder is _ in the shared folder.

Just to point out, there needs more to be done to make this package really usable, I just don't know how to do the fixes:

  • almost all binaries immediately stop with the error message that jack is either not installed or can't be connected to (no matter if jack runs or not). I think this is because they all need libjack.so.0. which somehow is not available (The file share/cadence/src/jacklib.py wants to load it).
    I tried to fix it by adding libjack2 to the buildinputs, but it made no difference. If somebody can point out how I can add libjack.so.0 to the path, I can add a fix in this pull request.
  • most included tools try to import dbus.mainloop.pyqt5 which seems to not exist in the dbus-python version available on nixos. E.g. the program claudia stops immediately saying DBus is not available. I guess we need to build a package containing dbus.mainloop.pyqt5 before we can fix this issue...
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 18, 2018
@c0bw3b
cadence: split native build inputs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a2867b1 
+ fix license : this is under GPL2+ and not MIT
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 25, 2018

Verified locally and everything seems in order between shell scripts, Python scripts and compiled binaries.

@c0bw3b
cadence: use fetchzip

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
7d78ba1 
because GitHub archives are not stable over time so better
to compute the hash of the unpacked content
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 25, 2018

@GrahamcOfBorg build cadence

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cadence

Partial log (click to expand)

/nix/store/00abkzag1iqr6fiwbad4x2qm7il3gxb1-cadence/share/cadence/src/catia.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/y78kh4c49qz3m8al5mmxqxanncfs4x0h-python3-3.7.1/bin/python3"
/nix/store/00abkzag1iqr6fiwbad4x2qm7il3gxb1-cadence/share/cadence/src/shared.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/y78kh4c49qz3m8al5mmxqxanncfs4x0h-python3-3.7.1/bin/python3"
/nix/store/00abkzag1iqr6fiwbad4x2qm7il3gxb1-cadence/share/cadence/src/claudia_launcher.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/y78kh4c49qz3m8al5mmxqxanncfs4x0h-python3-3.7.1/bin/python3"
/nix/store/00abkzag1iqr6fiwbad4x2qm7il3gxb1-cadence/share/cadence/src/patchcanvas.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/y78kh4c49qz3m8al5mmxqxanncfs4x0h-python3-3.7.1/bin/python3"
/nix/store/00abkzag1iqr6fiwbad4x2qm7il3gxb1-cadence/bin/cadence-pulse2loopback: interpreter directive changed from "/bin/bash" to "/nix/store/n2hjbpkf4c0m48945ivxs3lmsczzw2rg-bash-4.4-p23/bin/bash"
/nix/store/00abkzag1iqr6fiwbad4x2qm7il3gxb1-cadence/bin/cadence-pulse2jack: interpreter directive changed from "/bin/bash" to "/nix/store/n2hjbpkf4c0m48945ivxs3lmsczzw2rg-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/00abkzag1iqr6fiwbad4x2qm7il3gxb1-cadence...
postPatchMkspecs
postPatchMkspecs
/nix/store/00abkzag1iqr6fiwbad4x2qm7il3gxb1-cadence

@c0bw3b
cadence: limit to x64-linux

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
06b1613 
Broken on aarch64 because the Makefile pass
"-msse -mfpmath=sse" flags (x86 only)
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: cadence

Partial log (click to expand)

make[3]: Leaving directory '/build/qtwebengine-everywhere-src-5.11.1/src/core'
make[2]: *** [Makefile:80: sub-gn_run-pro-make_first] Error 2
make[2]: Leaving directory '/build/qtwebengine-everywhere-src-5.11.1/src/core'
make[1]: *** [Makefile:79: sub-core-make_first] Error 2
make[1]: Leaving directory '/build/qtwebengine-everywhere-src-5.11.1/src'
make: *** [Makefile:47: sub-src-make_first] Error 2
builder for '/nix/store/280x803mp96p5yyrg5lv83644g62v2ya-qtwebengine-5.11.1.drv' failed with exit code 2
cannot build derivation '/nix/store/2cypxvzsv9i7n6j3zsm9varz0sdcv8dl-python3.7-PyQt-5.10.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/p0w40c750hg5nkbwk8wbal7jxc1q9nf8-cadence.drv': 1 dependencies couldn't be built
error: build of '/nix/store/p0w40c750hg5nkbwk8wbal7jxc1q9nf8-cadence.drv' failed

@c0bw3b c0bw3b merged commit 21773f1 into NixOS:master Nov 25, 2018
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 25, 2018

Thanks @Melkor333

@deliciouslytyped deliciouslytyped mentioned this pull request Jan 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cadence pkg missing many commands
3 participants
@Melkor333 @c0bw3b @GrahamcOfBorg