nixos/clightning: init module #50531
Conversation
Signed-off-by: William Casarin <jb55@jb55.com>
| options = { | ||
|
|
||
| dataDir = mkOption { | ||
| type = types.path; |
| { | ||
| options = { | ||
| services.clightning = { | ||
| networks = mkOption { |
There was a problem hiding this comment.
The name networks seems to be a leftover from openvpn. I think nodes would be more fitting.
| # clightning requires bitcoin-cli to talk to either spruned or bitcoind | ||
| path = [ pkgs.altcoins.bitcoind ]; | ||
|
|
||
| after = [ "network.target" ]; |
There was a problem hiding this comment.
There's no network.target for user units (see systemctl --user list-units -t target). You can remove this dependency.
| config = mkIf (cfg.networks != {}) { | ||
|
|
||
| systemd.user.services = | ||
| listToAttrs (mapAttrsFlatten (name: value: nameValuePair "clightning-${name}" (mkLightningNode value name)) cfg.networks); |
There was a problem hiding this comment.
Can be simplified to
mapAttrs' (name: value: nameValuePair "clightning-${name}" (mkLightningNode value name)) cfg.networks;
| }; | ||
| } | ||
| ''; | ||
|
|
There was a problem hiding this comment.
I'd remove the whitespace here, one blank line should be enough.
| }; | ||
| }; | ||
| }); | ||
|
|
There was a problem hiding this comment.
Minor: These blank lines between brackets can be removed. There's more of them down below.
| config = mkOption { | ||
| type = types.lines; | ||
| description = '' | ||
| Configuration of this clightning node. |
There was a problem hiding this comment.
Can you link to the docs for the configuration here?
|
I'm having trouble getting both mainnet and testnet nodes to play nice together on the same machine, so I'm going to shelve this for now ... |
|
ooops nm I was just confused... |
|
I'm going to close this for now until I have time to fix some issues with it |
I copied a lot of stuff from the openvpn module for this one to support multiple networks at once.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)