Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] live555: 2018.02.28 -> 2018.10.17 #50613

Merged
merged 2 commits into from Nov 18, 2018
Merged

[18.09] live555: 2018.02.28 -> 2018.10.17 #50613

merged 2 commits into from Nov 18, 2018

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 18, 2018

Motivation for this change

Backport of #50612 addressing CVE-2018-4013
+ disabling live555 on aarch64 as it has been failing for a long time now

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

peterhoeg and others added 2 commits November 18, 2018 18:03
@peterhoeg @c0bw3b
live555: 2018.02.28 -> 2018.10.17
46d5ce2 
(cherry picked from commit fb81d62)
@c0bw3b
live555: broken on aarch64
d03b29f 
(cherry picked from commit 525e397)
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: live555

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: live555

Partial log (click to expand)


For more information about this source code (including your obligations under the LGPL), please see our FAQ at http://live555.com/liveMedia/faq.html
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ga4y66sky0d0a9hvj72b9l1fb1f1is83-live555-2018.10.17
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ga4y66sky0d0a9hvj72b9l1fb1f1is83-live555-2018.10.17/lib  /nix/store/ga4y66sky0d0a9hvj72b9l1fb1f1is83-live555-2018.10.17/bin
patching script interpreter paths in /nix/store/ga4y66sky0d0a9hvj72b9l1fb1f1is83-live555-2018.10.17
checking for references to /build in /nix/store/ga4y66sky0d0a9hvj72b9l1fb1f1is83-live555-2018.10.17...
/nix/store/ga4y66sky0d0a9hvj72b9l1fb1f1is83-live555-2018.10.17

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 18, 2018

Just to be sure:
@GrahamcOfBorg build vlc

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: vlc

Partial log (click to expand)

/nix/store/6pn8b4vq9s3hym7xzc91v737xrr81xhc-vlc-3.0.4/bin/nvlc: interpreter directive changed from " /bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/6pn8b4vq9s3hym7xzc91v737xrr81xhc-vlc-3.0.4/bin/qvlc: interpreter directive changed from " /bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/6pn8b4vq9s3hym7xzc91v737xrr81xhc-vlc-3.0.4/bin/rvlc: interpreter directive changed from " /bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/6pn8b4vq9s3hym7xzc91v737xrr81xhc-vlc-3.0.4/bin/cvlc: interpreter directive changed from " /bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/6pn8b4vq9s3hym7xzc91v737xrr81xhc-vlc-3.0.4/share/vlc/utils/video-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/6pn8b4vq9s3hym7xzc91v737xrr81xhc-vlc-3.0.4/share/vlc/utils/audio-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/6pn8b4vq9s3hym7xzc91v737xrr81xhc-vlc-3.0.4/share/vlc/utils/gnome-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/6pn8b4vq9s3hym7xzc91v737xrr81xhc-vlc-3.0.4...
postPatchMkspecs
/nix/store/6pn8b4vq9s3hym7xzc91v737xrr81xhc-vlc-3.0.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vlc

Partial log (click to expand)

/nix/store/n6yysyij2jf0757355qhmr2c8yhj47hi-vlc-3.0.4/share/vlc/utils/audio-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/n6yysyij2jf0757355qhmr2c8yhj47hi-vlc-3.0.4/share/vlc/utils/gnome-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/n6yysyij2jf0757355qhmr2c8yhj47hi-vlc-3.0.4/share/vlc/utils/video-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/n6yysyij2jf0757355qhmr2c8yhj47hi-vlc-3.0.4/bin/nvlc: interpreter directive changed from " /bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/n6yysyij2jf0757355qhmr2c8yhj47hi-vlc-3.0.4/bin/cvlc: interpreter directive changed from " /bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/n6yysyij2jf0757355qhmr2c8yhj47hi-vlc-3.0.4/bin/rvlc: interpreter directive changed from " /bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/n6yysyij2jf0757355qhmr2c8yhj47hi-vlc-3.0.4/bin/qvlc: interpreter directive changed from " /bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/n6yysyij2jf0757355qhmr2c8yhj47hi-vlc-3.0.4...
postPatchMkspecs
/nix/store/n6yysyij2jf0757355qhmr2c8yhj47hi-vlc-3.0.4

@c0bw3b c0bw3b merged commit 734cc38 into NixOS:release-18.09 Nov 18, 2018
@c0bw3b c0bw3b deleted the sec/1809/live555 branch December 6, 2018 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0bw3b @GrahamcOfBorg @peterhoeg