lib/fixed-points.nix: add an example for extends #50532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberth
reviewed
Nov 21, 2018
| @@ -41,6 +41,13 @@ rec { | |||
| # think of it as an infix operator `g extends f` that mimics the syntax from | |||
| # Java. It may seem counter-intuitive to have the "base class" as the second | |||
| # argument, but it's nice this way if several uses of `extends` are cascaded. | |||
| # | |||
There was a problem hiding this comment.
Needs a bit of introduction like "Let's see how extends evaluates the example."
There was a problem hiding this comment.
g itself should also be introduced as an example, which the pre-existing text fails to do.
There was a problem hiding this comment.
g is defined in the text above the context
- helped me understand how extends works, hopefully it can help others too
typetetris
force-pushed
the
add-extends-example
branch
from
019cb04
to
3cc83df
Compare
|
I added some introductory text and mentioned, that I use the |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Just add an example for how extends unfolds, so one can easier
understand how it works.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)