kakoune: Prefix version with 'v' #50617
Conversation
Turns out there's some tooling parsing the version number and having a 'v' prefix works better in that case. I tested that it builds & works fine on NixOS. See: kakoune-lsp/kakoune-lsp#99
There was a problem hiding this comment.
No that's wrong. In nixpkgs a version must start with a number
https://nixos.org/nixpkgs/manual/#sec-package-naming
The version part of the name attribute must start with a digit (following a dash) — e.g., "hello-0.3.1rc2".
|
Oh, I did not know that. Thank you @c0bw3b , closing the PR. I'll re-open this one and modify it to only modify the build script. |
This reverts commit 2fc95cc.
|
To be more informative here, the reason is because nix will parse that to find the package name on one side, and the version number on the other. With what you were doing it would have ended like this : nix-repl> test = "kakoune-unstable-v2018.10.27"
nix-repl> builtins.parseDrvName test
{ name = "kakoune-unstable-v2018.10.27"; version = ""; } |
|
@c0bw3b In which cases Nix needs to parse the package name? |
|
Every time it evaluates the whole <nixpkgs> set |
|
@utdemir it is used in nix-env for updating packages. |
|
@GrahamcOfBorg build kakoune |
|
Success on x86_64-linux (full log) Attempted: kakoune Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: kakoune Partial log (click to expand)
|
|
@utdemir this is complete for you? You don't have more additions to bring to this PR? |
|
@c0bw3b Yes, this is complete for me; I think we can merge it if everything is good. Thank you very much! |
Turns out there's some tooling parsing the version number and having a
'v' prefix works better in that case.
See: kakoune-lsp/kakoune-lsp#99
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)