Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graalvm8: add passthru.home #50515

Merged
merged 1 commit into from Nov 17, 2018
Merged

graalvm8: add passthru.home #50515

merged 1 commit into from Nov 17, 2018

Conversation

Tomahna
Copy link
Contributor

@Tomahna Tomahna commented Nov 17, 2018

Motivation for this change

I've tried to setup graalvm8 as the default jre with a packageOverrides. However some derivations like sbt require jre.home.

Things done

added graalvm8.home

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

jre.home is required by other derivations like sbt
@Mic92
Copy link
Member

Mic92 commented Nov 17, 2018

cc @volth

@Mic92 Mic92 merged commit f97d9d1 into NixOS:master Nov 17, 2018
@Tomahna Tomahna deleted the graalvm8Home branch November 23, 2018 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants