Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-mnist: init at 0.6 #50655

Merged
merged 1 commit into from Nov 29, 2018
Merged

python-mnist: init at 0.6 #50655

merged 1 commit into from Nov 29, 2018

Conversation

CMCDragonkai
Copy link
Member

Motivation for this change

This adds the python-mnist Python package that acts as a "parser" and loader of MNIST and EMNIST data.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@CMCDragonkai
Copy link
Member Author

To run the tests of this package, we need this other package: #50448 to be first merged. This is because the tests rely on the dataset: https://github.com/sorki/python-mnist/blob/master/test.sh

@CMCDragonkai
Copy link
Member Author

I've noticed that astroquery line in all-packages.nix as a space at the end and that doesn't fit the .editorconfig. I removed out that edit.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 29, 2018

@GrahamcOfBorg build python2Packages.python-mnist python3Packages.python-mnist

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2Packages.python-mnist, python3Packages.python-mnist

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
writing manifest file 'python_mnist.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/h4dxzrz8r9h7blmpnsr1mw8vwi2c27xc-python2.7-python-mnist-0.6
/nix/store/3bngxlhks8hr42i7ah6c53vgfvrhivs9-python3.7-python-mnist-0.6

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2Packages.python-mnist, python3Packages.python-mnist

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
writing manifest file 'python_mnist.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/955cn7a2hbxgzghp07rjw5kjb1svi3yf-python2.7-python-mnist-0.6
/nix/store/8pks3rzacsncls8hll1spg82gidmlf8g-python3.7-python-mnist-0.6

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2Packages.python-mnist, python3Packages.python-mnist

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
writing manifest file 'python_mnist.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/r5kvf1k3z65zrj720206bq1n6j6km8sn-python2.7-python-mnist-0.6
/nix/store/0bhahxmsbgc47n8y8vfq16qqlx3vn1kn-python3.7-python-mnist-0.6

@c0bw3b c0bw3b merged commit 1a9e12e into NixOS:master Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CMCDragonkai @c0bw3b @GrahamcOfBorg