Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.beaker: 1.8.0 -> 1.10.0 #50537

Closed
wants to merge 1 commit into from
Closed

python.pkgs.beaker: 1.8.0 -> 1.10.0 #50537

wants to merge 1 commit into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 18, 2018 •
edited

Motivation for this change

part of https://discourse.nixos.org/t/nixpkgs-update-r-ryantm-logs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from FRidh as a code owner November 18, 2018 01:00
@Mic92
Copy link
Member Author

Mic92 commented Nov 18, 2018 

@GrahamcOfBorg build pyload python27Packages.beaker python27Packages.pyramid_beaker python36Packages.beaker python36Packages.pyramid_beaker

@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@Mic92 Mic92 mentioned this pull request Nov 18, 2018
Open
@ryantm
Copy link
Member

ryantm commented Feb 24, 2019

@Mic92 Is this blocked by the Darwin failures?

@Mic92
Copy link
Member Author

Mic92 commented Feb 24, 2019

I forgot what the status of this pr was:

@GrahamcOfBorg build pyload python27Packages.beaker python27Packages.pyramid_beaker python36Packages.beaker python36Packages.pyramid_beaker

ryantm
ryantm requested changes Feb 24, 2019
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs fixes for Darwin?

@Mic92
Copy link
Member Author

Mic92 commented Feb 26, 2019

Alternative is to ignore tests.test_cache.test_upgrade for macOS since also upstream does not seems to be keen in fixing it. dbm support seems to be only a small part of the library after all.

1 similar comment
@Mic92
Copy link
Member Author

Mic92 commented Feb 26, 2019

Alternative is to ignore tests.test_cache.test_upgrade for macOS since also upstream does not seems to be keen in fixing it. dbm support seems to be only a small part of the library after all.

@Zer0- Zer0- mentioned this pull request Mar 25, 2019
Merged
10 tasks
@Mic92 Mic92 deleted the python.pkgs.beaker branch January 15, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @GrahamcOfBorg @ryantm @infinisil