Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buck: use upstream version convention #50566

Merged
merged 1 commit into from
Nov 18, 2018
Merged

buck: use upstream version convention #50566

merged 1 commit into from
Nov 18, 2018
+3 −3

Conversation

layus
Copy link
Member

@layus layus commented Nov 18, 2018

Changes added in 4d1fd37 break
automated updates by moving to a custom version scheme.

This switches back to upstream versioning, while maintaining version
schema convention of builtins.parseDrvName.
See also issue #43717

This will help r-ryantm automated updates

2018-11-10T18:50:52 buck-unstable 2017-10-01 -> 2018.10.29.01
2018-11-10T18:51:02 Source url did not change.
2018-11-10T18:51:02 FAIL

/cc @r-ryantm ;-), @ryantm, @pSub, @matthewbauer

@layus
buck: use upstream version convention

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
de8fe66 
Changes added in 4d1fd37 break
automated updates by moving to a custom version scheme.

This switches back to upstream versioning, while maintaining version
schema convention of `builtins.parseDrvName`.

See issue NixOS#43717
@Mic92
Copy link
Member

Mic92 commented Nov 18, 2018

@GrahamcOfBorg build buck

@NixOS NixOS deleted a comment from GrahamcOfBorg Nov 18, 2018
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: buck

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@NixOS NixOS deleted a comment from GrahamcOfBorg Nov 18, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Nov 18, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: buck

Partial log (click to expand)

BUILDING: FINISHED IN 5.7s (100%) 26/26 JOBS, 1 UPDATED, 3.8% CACHE MISS
BUILD SUCCEEDED
installing
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/bcy65yn6v3ydjx4ah17j84nq2ml640qg-buck-2017.10.01.01/bin
patching script interpreter paths in /nix/store/bcy65yn6v3ydjx4ah17j84nq2ml640qg-buck-2017.10.01.01
/nix/store/bcy65yn6v3ydjx4ah17j84nq2ml640qg-buck-2017.10.01.01/bin/.buck-wrapped: interpreter directive changed from "/usr/bin/env python2.7" to "/nix/store/c6mnc84yva1wa85nzjfha6mxfsk6qbg7-python-2.7.15/bin/python2.7"
/nix/store/bcy65yn6v3ydjx4ah17j84nq2ml640qg-buck-2017.10.01.01/bin/.buckd-wrapped: interpreter directive changed from "/usr/bin/env python2.7" to "/nix/store/c6mnc84yva1wa85nzjfha6mxfsk6qbg7-python-2.7.15/bin/python2.7"
/nix/store/bcy65yn6v3ydjx4ah17j84nq2ml640qg-buck-2017.10.01.01

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: buck

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4v1ig7zgz05lrnm9b8bs0wznnahx7sfp-buck-2017.10.01.01
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4v1ig7zgz05lrnm9b8bs0wznnahx7sfp-buck-2017.10.01.01/bin
patching script interpreter paths in /nix/store/4v1ig7zgz05lrnm9b8bs0wznnahx7sfp-buck-2017.10.01.01
/nix/store/4v1ig7zgz05lrnm9b8bs0wznnahx7sfp-buck-2017.10.01.01/bin/.buck-wrapped: interpreter directive changed from "/usr/bin/env python2.7" to "/nix/store/2brlr94ahy3a9mvcjy0qbqpv8zrb7b7s-python-2.7.15/bin/python2.7"
/nix/store/4v1ig7zgz05lrnm9b8bs0wznnahx7sfp-buck-2017.10.01.01/bin/.buckd-wrapped: interpreter directive changed from "/usr/bin/env python2.7" to "/nix/store/2brlr94ahy3a9mvcjy0qbqpv8zrb7b7s-python-2.7.15/bin/python2.7"
checking for references to /build in /nix/store/4v1ig7zgz05lrnm9b8bs0wznnahx7sfp-buck-2017.10.01.01...
/nix/store/4v1ig7zgz05lrnm9b8bs0wznnahx7sfp-buck-2017.10.01.01

@Mic92 Mic92 merged commit d208fa5 into NixOS:master Nov 18, 2018
@layus layus deleted the tmp/buck-version branch November 18, 2018 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@layus @Mic92 @GrahamcOfBorg