Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove: Visual Studio project files for earlier than 2015 #6960

Merged
merged 2 commits into from Nov 18, 2018

Conversation

nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Nov 1, 2018

Builds with Visual C++ versions older than 2015 probably don't work any longer, and nobody should be using those anyway. Remove the project files for it.

glx22
glx22 previously approved these changes Nov 1, 2018
@nielsmh
Copy link
Contributor Author

nielsmh commented Nov 18, 2018

Waiting on this or a similar fix: OpenTTD/OpenTTD-git-hooks#7

@nielsmh
Copy link
Contributor Author

nielsmh commented Nov 18, 2018

Someone will still need to override the commit hooks for this to pass, but now it should be obvious why it fails. (Can't touch files with missing newline at the end as it is right now.)

@TrueBrain
Copy link
Member

@glx22: can you confirm everything is still in working order with this PR? After that, we can simply merge it (ignoring CI results).

@TrueBrain TrueBrain merged commit 476643b into OpenTTD:master Nov 18, 2018
@nielsmh nielsmh deleted the remove-old-vcprojs branch January 5, 2019 17:02
PeterN added a commit to PeterN/OpenTTD that referenced this pull request Jan 21, 2019
nielsmh pushed a commit to nielsmh/OpenTTD that referenced this pull request Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants