Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] harfbuzzFull: fix CoreText support #50608

Closed
wants to merge 1 commit into from

Conversation

alyssais
Copy link
Member

Motivation for this change

When harfbuzz is built with ICU, it needs to be built from a non-ICU harfbuzz. For CoreText to work with the ICU build, it needs to have been enabled on the non-ICU one, as well as the ICU one. This means that we can't just use the standard harfbuzz from nixpkgs. Instead, call our builder twice - once for the non-ICU version, then once for the ICU version, to ensure the build options between the two are identical (other than withIcu).

cc @LnL7

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

When harfbuzz is built with ICU, it needs to be built from a non-ICU
harfbuzz. For CoreText to work with the ICU build, it needs to have been
enabled on the non-ICU one, as well as the ICU one. This means that we
can't just use the standard `harfbuzz` from nixpkgs. Instead, call our
builder twice - once for the non-ICU version, then once for the ICU
version, to ensure the build options between the two are identical
(other than `withIcu`).
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: harfbuzzFull

Partial log (click to expand)

/nix/store/iba7jg6p5i4z6vjqd3aphvrszihkmswm-harfbuzz-icu-1.9.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: harfbuzzFull

Partial log (click to expand)

/nix/store/1xn9hcyby12pwak8msfh4kx556nx7bam-harfbuzz-icu-1.9.0

@alyssais
Copy link
Member Author

Actually, this might not be the fix – the libharfbuzz-icu dylibs still don't have the coretext symbols…

@Mic92
Copy link
Member

Mic92 commented Nov 18, 2018

@GrahamcOfBorg build harfbuzzFull

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: harfbuzzFull

Partial log (click to expand)

/nix/store/1xn9hcyby12pwak8msfh4kx556nx7bam-harfbuzz-icu-1.9.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: harfbuzzFull

Partial log (click to expand)

/nix/store/iba7jg6p5i4z6vjqd3aphvrszihkmswm-harfbuzz-icu-1.9.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: harfbuzzFull

Partial log (click to expand)

/nix/store/izyw0bbjm32s9lv26zr8hmi6s4pg9scn-harfbuzz-icu-1.9.0/lib/libharfbuzz-icu.0.dylib: fixing dylib
/nix/store/izyw0bbjm32s9lv26zr8hmi6s4pg9scn-harfbuzz-icu-1.9.0/lib/libharfbuzz-subset.0.dylib: fixing dylib
/nix/store/izyw0bbjm32s9lv26zr8hmi6s4pg9scn-harfbuzz-icu-1.9.0/lib/libharfbuzz-icu.0.dylib: fixing dylib
/nix/store/izyw0bbjm32s9lv26zr8hmi6s4pg9scn-harfbuzz-icu-1.9.0/lib/libharfbuzz-subset.0.dylib: fixing dylib
/nix/store/izyw0bbjm32s9lv26zr8hmi6s4pg9scn-harfbuzz-icu-1.9.0/lib/libharfbuzz-icu.0.dylib: fixing dylib
/nix/store/izyw0bbjm32s9lv26zr8hmi6s4pg9scn-harfbuzz-icu-1.9.0/lib/libharfbuzz-subset.0.dylib: fixing dylib
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/7cj239y5rz52wk4sfzq7g93cw9kjckag-harfbuzz-icu-1.9.0-dev/lib  /nix/store/7cj239y5rz52wk4sfzq7g93cw9kjckag-harfbuzz-icu-1.9.0-dev/bin
patching script interpreter paths in /nix/store/7cj239y5rz52wk4sfzq7g93cw9kjckag-harfbuzz-icu-1.9.0-dev
/nix/store/izyw0bbjm32s9lv26zr8hmi6s4pg9scn-harfbuzz-icu-1.9.0

@Mic92 Mic92 changed the title harfbuzzFull: fix CoreText support [WIP] harfbuzzFull: fix CoreText support Nov 18, 2018
@alyssais alyssais closed this Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants