[WIP] harfbuzzFull: fix CoreText support #50608
Closed
+60
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When harfbuzz is built with ICU, it needs to be built from a non-ICU harfbuzz. For CoreText to work with the ICU build, it needs to have been enabled on the non-ICU one, as well as the ICU one. This means that we can't just use the standard `harfbuzz` from nixpkgs. Instead, call our builder twice - once for the non-ICU version, then once for the ICU version, to ensure the build options between the two are identical (other than `withIcu`).
|
Success on x86_64-linux (full log) Attempted: harfbuzzFull Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: harfbuzzFull Partial log (click to expand)
|
|
Actually, this might not be the fix – the libharfbuzz-icu dylibs still don't have the coretext symbols… |
|
@GrahamcOfBorg build harfbuzzFull |
|
Success on aarch64-linux (full log) Attempted: harfbuzzFull Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: harfbuzzFull Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: harfbuzzFull Partial log (click to expand)
|
Mic92
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
When harfbuzz is built with ICU, it needs to be built from a non-ICU harfbuzz. For CoreText to work with the ICU build, it needs to have been enabled on the non-ICU one, as well as the ICU one. This means that we can't just use the standard
harfbuzzfrom nixpkgs. Instead, call our builder twice - once for the non-ICU version, then once for the ICU version, to ensure the build options between the two are identical (other thanwithIcu).cc @LnL7
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)