Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 74f9e555d3b9
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: f6fd7f44c7ef
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Nov 17, 2018

  1. hashcat: 4.2.1 -> 5.0.0 

    This introduces a dependency on xxHash. Unfortunately, hashcat's
build system wants to rebuild xxHash from the source code located
in `<hashcat source root>/deps/git/xxHash`, a Git submodule whose
contents are not included in the source tarball we currently
download.

This could be fixed by either using a recursive git clone instead
a tarball download, or patching the build files to use an existing
installation of xxHash (i.e. the one already provided by Nix). I
believe the latter is preferable since it avoids the situation in
which the xxHash version used by hashcat is different to the xxHash
version used by all other Nix packages.

Fortunately, this situation has been greatly improved [1] since
release 5.0.0; the next release of hashcat should drop usage of
git submodules and provide better support for using existing
installations of dependencies.

[1] hashcat/hashcat@4177e1e
    @kierdavis
    kierdavis committed Nov 17, 2018
    Copy the full SHA
    df462d0 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2018

  1. Merge pull request #50523 from kierdavis/hashcat-5.0.0 

    hashcat: 4.2.1 -> 5.0.0
    @Mic92
    Mic92 committed Nov 18, 2018
    Copy the full SHA
    f6fd7f4 View commit details
    Browse the repository at this point in the history