Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jflex urls, and version by the way #50631

Merged
merged 3 commits into from Nov 19, 2018
Merged

Update jflex urls, and version by the way #50631

merged 3 commits into from Nov 19, 2018

Conversation

layus
Copy link
Member

@layus layus commented Nov 18, 2018

This is my @ryantm fixing spree ;-)
The download url has changed, and new versions could not be downloaded anymore.

@c0bw3b c0bw3b added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 18, 2018
@Mic92
Copy link
Member

Mic92 commented Nov 18, 2018 

$ jflex
/nix/store/nnb3g9n6n28l2zsqakd0li3bsjp5374k-jflex-1.7.0/bin/jflex: line 48: java: command not found

Another makeWrapper add java to the PATH could fix this.

@layus
Copy link
Member Author

layus commented Nov 19, 2018

@c0bw3b Not sure it needs a port to stable. The old urls still works for 1.6.1.
@Mic92 Fixed by patching the script

I think it is ready to ship ;-)

@c0bw3b c0bw3b removed the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 19, 2018
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 19, 2018

@layus ah thanks for the clarification, I misunderstood you first post

@Mic92 Mic92 merged commit 5ad46ce into NixOS:master Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@layus @Mic92 @c0bw3b @GrahamcOfBorg