Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of dead packages after Gna.org closure #50614

Merged
merged 7 commits into from Nov 20, 2018
Merged

Cleanup of dead packages after Gna.org closure #50614

merged 7 commits into from Nov 20, 2018

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 18, 2018 •
edited

Motivation for this change

Gna.org forge has been closed for a while now. See archived announce.
I've updated packages that move elsewhere in the last few months, now comes the time to remove the ones that disappeared along with the forge.

  • blackshades-elite cc @viric
  • smbldap-tools legacy, Samba3-only
  • remember is now a mode of base emacs so was irrelevant as an external plugin anyway
  • poker-eval cc @Zert and its Haskell bindings
  • bins no homepage / no source repo / no maintainers
  • pdfshuffler was just marked broken and not removed since its SF.net repo may still be alive @Mic92 removed too
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 18, 2018 •
edited

Oh I missed that poker-eval was referenced in Haskell packages...

@ryantm @basvandijk @peti can one of you remove haskellPackages.poker-eval properly? I have no clue about Haskell packaging, I just know that hackage-packages.nix is auto-generated and that I should not mess with it manually 🐈

@Mic92
Copy link
Member

Mic92 commented Nov 18, 2018

pdfshuffler can be also removed.

@Mic92
Copy link
Member

Mic92 commented Nov 18, 2018

There is an active fork of it, if somebody is interested in packaging it: https://github.com/jeromerobert/pdfarranger

@peti
Copy link
Member

peti commented Nov 19, 2018 •
edited

@c0bw3b, we package every package on Hackage. So we won't drop power-eval even if it no longer builds. What should be done is to replace the reference to pkgs.poker-eval in pkgs/development/haskell-modules/hackage-packages.nix by null to avoid evaluation errors.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 19, 2018 •
edited

Okay, thanks for the explanation.
It would mean change it to:

  "poker-eval" = callPackage
    ({ mkDerivation, array, base, mtl, poker-eval, random, vector }:
     mkDerivation {
       pname = "poker-eval";
       version = "0.3.1";
       sha256 = "0v1is9jnpw1ij3b7h9figkjqk58dzc44v6vpdmxfmb80w0myihrv";
       libraryHaskellDepends = [ array base mtl random vector ];
       librarySystemDepends = [ poker-eval ];
       description = "Binding to libpoker-eval";
       license = stdenv.lib.licenses.publicDomain;
     }) {poker-eval = null;};

( instead of inherit (pkgs) poker-eval; on the last line )

But am I allowed to edit that manually in hackage-packages.nix?

@peti
Copy link
Member

peti commented Nov 20, 2018

But am I allowed to edit that manually in hackage-packages.nix?

Yes. At some point in the future, hackage2nix will re-generate the file, but it will generate the exact same code that you've cited above.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 20, 2018

Thank you @peti
I will complete this PR later today

@c0bw3b
blackshades-elite-svn: remove
fd90988 
Gna.org forge is closed and upstream repo was not relocated
@c0bw3b
smbldap-tools: remove
bd73a3f 
Gna.org forge is closed and upstream repo was not relocated
@c0bw3b
remember: remove
cc7e724 
Gna.org forge is closed and upstream repo was not relocated
+ remember-mode is part of the base Emacs since 26.1
@c0bw3b
poker-eval: remove
d870a2d 
Gna.org forge is closed and upstream repo was not relocated
@c0bw3b
bins: remove
149e467 
Gna.org forge is closed and upstream repo was not relocated
@c0bw3b
pdfshuffler: remove
2c12a92 
Gna.org forge is closed
@c0bw3b
haskellPackages.poker-eval: obsolete
db8991b 
libpoker-eval is removed from nixpkgs
@c0bw3b c0bw3b merged commit c5e4c0f into NixOS:master Nov 20, 2018
@c0bw3b c0bw3b deleted the pkg/gna-cleanup branch December 6, 2018 20:10
@c0bw3b c0bw3b added this to To do in Picking up garbage via automation May 10, 2019
@c0bw3b c0bw3b moved this from To do to Done in Picking up garbage May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: emacs 6.topic: haskell 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
Picking up garbage
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@c0bw3b @Mic92 @peti @GrahamcOfBorg