Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetchurl: mirrors: http -> https, https before http, http before ftp #50560

Merged
merged 1 commit into from Nov 23, 2018

Conversation

oxij
Copy link
Member

@oxij oxij commented Nov 18, 2018

Because HTTP has a higher probability of working behind proxies.

http://ftp.tuwien.ac.at/pub/CPAN/
http://ftp.funet.fi/pub/CPAN/
https://cpan.metacpan.org/
http://cpan.perl.org/
ftp://download.xs4all.nl/pub/mirror/CPAN/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this one at all?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also seems to have https: https://download.xs4all.nl/mirror/CPAN/

ftp://download.xs4all.nl/pub/mirror/CPAN/
https://ftp.gwdg.de/pub/languages/perl/CPAN/
https://cpan.metacpan.org/
https://cpan.perl.org/
http://ftp.tuwien.ac.at/pub/CPAN/
http://ftp.funet.fi/pub/CPAN/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can delete the http mirrors here, when we have better alternatives.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. Our binary cache, most of the sources and a good part of the internet these days are barely usable without https.

Because HTTP has a higher probability of working behind proxies.
@oxij
Copy link
Member Author

oxij commented Nov 22, 2018

It also seems to have https: https://download.xs4all.nl/mirror/CPAN/

Added.

I think we can delete the http mirrors here, when we have better alternatives.

Well, it's not like it hurts to have them there.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 22, 2018

Regarding http -> https it's worth noting that we are going to pass --insecure to curl anyway.
But:

  • In the case of all SourceForge servers http:// redirects to https:// so we save an exchange by using https directly
  • In the case of ftpmirror.gnu.org you just get redirected to a different mirror that will honor the protocol you requested in the first place. I guess there is a similar number of mirrors available in each pool.

@Mic92 Mic92 merged commit c424c11 into NixOS:master Nov 23, 2018
@Mic92
Copy link
Member

Mic92 commented Nov 23, 2018

Is this also the case for nix-prefetch-url?

@oxij oxij deleted the pkgs/fetchurl-mirrors branch August 12, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants