lib: implement setPrio
#50561
Merged
lib: implement setPrio
#50561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Nov 18, 2018
lib/meta.nix
Outdated
| */ | ||
| mapDerivationAttrset = f: set: lib.mapAttrs (name: pkg: if lib.isDerivation pkg then (f pkg) else pkg) set; | ||
|
|
||
| /* Set the nix-env priority of the package. | ||
| */ | ||
| setPrio = priority: drv: addMetaAttrs { inherit priority; } drv; |
There was a problem hiding this comment.
is this not basically the same as?
addMetaAttrs { priority = 10; } drv;
There was a problem hiding this comment.
I think this is a no-op readability change; do you think exposing implementation is better?
(for example, if there are other frequent meta overrides, improving visibility of addMetaAttrs could be indeed useful)
For when `hiPrio` and `lowPrio` are not enough.
|
I think this is a no-op readability change; do you think exposing implementation is better?
Well, to me it just seems strange to expose just two particular priority values out of the whole range.
I do use `setPrio` in my config to influence the priority of the manual pages.
(for example, if there are other frequent `meta` overrides, improving visibility of `addMetaAttrs` could be indeed useful)
I don't think I use any others, though.
|
7c6f434c
approved these changes
Nov 22, 2018
|
ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For when
hiPrioandlowPrioare not enough.