Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playerctl: 0.6.1 -> 2.0.1 #52150

Merged
merged 4 commits into from Dec 20, 2018
Merged

playerctl: 0.6.1 -> 2.0.1 #52150

merged 4 commits into from Dec 20, 2018

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/playerctl/versions.

meta.description for playerctl is: '"Command-line utility and library for controlling media players that implement MPRIS"'.

Release on GitHub

Compare changes on GitHub

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

13 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
4 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
4 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
i3blocks
i3lock-pixeled
playerctl
yabar-unstable

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/z1j65p655q7xd4m3bii9fq04cxwdwy1v-playerctl-2.0.1 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A playerctl https://github.com/r-ryantm/nixpkgs/archive/00f570005752e41a15d34b213a962b0f16bfac1d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/z1j65p655q7xd4m3bii9fq04cxwdwy1v-playerctl-2.0.1
ls -la /nix/store/z1j65p655q7xd4m3bii9fq04cxwdwy1v-playerctl-2.0.1/bin

cc @puffnfresh for testing.

Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/playerctl/versions
@jtojnar
Copy link
Contributor

jtojnar commented Dec 16, 2018

gtk-doc should now work: altdesktop/playerctl@686cbaa cc @hedning

@worldofpeace
Copy link
Contributor

gtk-doc should now work: acrisci/playerctl@686cbaa cc @hedning

Addressed in 59f8d67

Build fails with:
../playerctl/playerctl-player.c:274:19: error: use of undeclared identifier 'CLOCK_MONOTONIC'
    clock_gettime(CLOCK_MONOTONIC, &player->priv->cached_position_monotonic);
@hedning
Copy link
Contributor

hedning commented Dec 19, 2018

Breaks yabar-unstable. cc @Ma27 as I noticed you contribute upstream to yabar.

Result of nix-review pr 52150

1 package failed to build: - yabar-unstable
3 package were build: - i3blocks - i3lock-pixeled - playerctl

@Ma27
Copy link
Member

Ma27 commented Dec 19, 2018

Thanks a lot for pinging me. I'll try to have a look at this tonight :)

@Ma27
Copy link
Member

Ma27 commented Dec 20, 2018

So, I'm afraid that it's not that easy to do the upgrade in the yabar sources, also it's questionable when I'll have time to do that.
Until the you could do one the following things:

  • supporting multiple versions of playerctl (unless there are security concerns)
  • disabling playerctl support in yabar (by setting PLAYERCTL=0 in the build

Mic92 added a commit to Mic92/yabar that referenced this pull request Dec 20, 2018
Apparently they renamed there pkg-config file.
Noticed in NixOS/nixpkgs#52150
@Mic92
Copy link
Member

Mic92 commented Dec 20, 2018

third option is to patch yabar to support the new playerctl.

@Ma27
Copy link
Member

Ma27 commented Dec 20, 2018

I just had a look at the error last night and was unsure if it was necessary to fix the code itself, not just the build environent.

But thanks a lot for having a deeper look here 👍

@Mic92 Mic92 merged commit 84fb36b into NixOS:master Dec 20, 2018
@r-ryantm r-ryantm deleted the auto-update/playerctl branch December 24, 2018 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants