Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashcash: init at 1.22 #52075

Merged
merged 6 commits into from Jan 8, 2019
Merged

hashcash: init at 1.22 #52075

merged 6 commits into from Jan 8, 2019

Conversation

kisonecat
Copy link
Contributor

Motivation for this change

Hashcash is available in the AUR and missing in nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Dec 14, 2018

@GrahamcOfBorg build hashcash

Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unrelated commits.

pkgs/tools/security/hashcash/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/hashcash/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/hashcash/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/hashcash/default.nix Outdated Show resolved Hide resolved
@kisonecat
Copy link
Contributor Author

My mistake -- I've removed the extraneous commits now so this PR is just hashcash.

@jtojnar
Copy link
Contributor

jtojnar commented Jan 8, 2019

@GrahamcOfBorg build hashcash

@jtojnar jtojnar merged commit 153c0bd into NixOS:master Jan 8, 2019
@jtojnar
Copy link
Contributor

jtojnar commented Jan 8, 2019

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants