Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.spacy: 2.0.16 -> 2.0.18 #52187

Merged
merged 2 commits into from Dec 15, 2018
Merged

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Update spaCy to 2.0.18. Also, it seems that we cannot build spaCy on Python 2 anymore, since one of its transitive dependencies (ftfy) does not work with Python 2 anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@@ -66,7 +66,8 @@ buildPythonPackage rec {
substituteInPlace setup.py \
--replace "pathlib==1.0.1" "pathlib>=1.0.0,<2.0.0" \
--replace "plac>=0.9.6,<1.0.0" "plac>=0.9.6" \
--replace "wheel>=0.32.0,<0.33.0" "wheel>=0.31.0"
--replace "wheel>=0.32.0,<0.33.0" "wheel>=0.31.0" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be removed.

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if propagatedBuildInputs is still up to date: https://github.com/explosion/thinc/blob/v6.12.1/setup.py#L163-L177

@danieldk
Copy link
Contributor Author

I have moved some of the dependencies to checkInputs since they are only used for unit tests (which are disabled). I also removed two unused dependencies from the spacy derivation.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python3.pkgs.spacy python2.pkgs.thinc python3.pkgs.thinc

@dotlambda dotlambda merged commit b1519e6 into NixOS:master Dec 15, 2018
@danieldk danieldk deleted the spacy-2.0.18 branch December 15, 2018 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants