Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gif for cli #52201

Merged
merged 2 commits into from Dec 31, 2018
Merged

Gif for cli #52201

merged 2 commits into from Dec 31, 2018

Conversation

Scriptkiddi
Copy link
Contributor

Motivation for this change

Wanted to use it for my dotfiles

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Scriptkiddi Scriptkiddi mentioned this pull request Dec 15, 2018
Closed
9 tasks
@Scriptkiddi
Copy link
Contributor Author

@dotlambda hey I reopened this as a new PR because the rebasing was causing problems I hope you do not mind, I fixed everything now besides the NixOs tests

dotlambda
dotlambda requested changes Dec 15, 2018
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a commit that adds yourself to the maintainer list.

pkgs/development/python-modules/x256/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/gif-for-cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/gif-for-cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/gif-for-cli/default.nix Show resolved Hide resolved
alyssais
alyssais reviewed Dec 15, 2018
View reviewed changes
pkgs/tools/misc/gif-for-cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/gif-for-cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/gif-for-cli/default.nix Outdated Show resolved Hide resolved
@Scriptkiddi Scriptkiddi force-pushed the gif-for-cli branch 3 times, most recently from f177fd2 to 78cfe03 Compare December 17, 2018 05:55
dotlambda
dotlambda requested changes Dec 17, 2018
View reviewed changes
pkgs/development/python-modules/x256/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/gif-for-cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/gif-for-cli/default.nix Outdated Show resolved Hide resolved
dotlambda
dotlambda requested changes Dec 18, 2018
View reviewed changes
pkgs/development/python-modules/x256/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/gif-for-cli/default.nix Outdated Show resolved Hide resolved
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.x256 python3.pkgs.x256

@dotlambda
Copy link
Member

@GrahamcOfBorg build gif-for-cli

@dotlambda
Copy link
Member

Ran 0 tests in 0.000s

Please provide an appropriate checkPhase or set doCheck = false and add a comment with the reason.

@Scriptkiddi Scriptkiddi force-pushed the gif-for-cli branch 2 times, most recently from 64854ea to 5d0a5a3 Compare December 21, 2018 03:11
dotlambda
dotlambda requested changes Dec 23, 2018
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version and commit message for gif-for-cli still need to be corrected wrt the date.

@Scriptkiddi
Copy link
Contributor Author

@dotlambda thanks for taking the time to go with me through that PR merry christmas

@dotlambda
Copy link
Member

You need to squash the two new commits into the appropriate ones.

@infinisil
Copy link
Member

All feedback seems to have been addressed

@infinisil infinisil merged commit 78f80a6 into NixOS:master Dec 31, 2018
@Scriptkiddi Scriptkiddi deleted the gif-for-cli branch January 2, 2019 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais left review comments

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Scriptkiddi @dotlambda @infinisil @alyssais @GrahamcOfBorg