Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "gcc-arm-embedded: remove" #52146

Merged
merged 1 commit into from Dec 15, 2018
Merged

Revert "gcc-arm-embedded: remove" #52146

merged 1 commit into from Dec 15, 2018

Conversation

matthewbauer
Copy link
Member

@matthewbauer matthewbauer commented Dec 15, 2018 •
edited

This (fully) reverts commit c327df5.

Fixes #51907.

some people still need gcc-arm-embedded to be available.

/cc @ejpcmac

Ekleog
Ekleog reviewed Dec 15, 2018
View reviewed changes
pkgs/development/compilers/gcc-arm-embedded/default.nix
@@ -0,0 +1,50 @@
{ stdenv, bzip2, patchelf, glibc, gcc, fetchurl, version, releaseType, sha256, ncurses
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not used in this partial revert (it was used only pre-gcc6 before the removing commit).

I'd think either drop it, or re-add gcc<6 to all-packages?

@rasendubi
Copy link
Member

I vote for a full revert, as some people may still use previous versions. (It is common for embedded projects to break after a gcc upgrade.)

@matthewbauer matthewbauer changed the title Partial revert of "gcc-arm-embedded: remove" Revert "gcc-arm-embedded: remove" Dec 15, 2018
@matthewbauer
Copy link
Member Author

Yeah I'll just revert the whole thing.

@ejpcmac
Copy link
Contributor

ejpcmac commented Dec 15, 2018

I vote for a full revert, as some people may still use previous versions. (It is common for embedded projects to break after a gcc upgrade.)

Yes, this is indeed the case. We are currently using gcc-arm-embedded-4_9 for a project. One of our dependencies has been tested with this version of GCC and we cannot take the risk to see some erratic behaviour due to some new optimisations or other differences in the binary generated by newer versions of GCC.

@matthewbauer matthewbauer merged commit e422585 into NixOS:master Dec 15, 2018
@rasendubi rasendubi mentioned this pull request Jan 11, 2019
Merged
10 tasks
@matthewbauer matthewbauer deleted the readd-gcc-arm-embedded branch February 22, 2019 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ekleog Ekleog Ekleog left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matthewbauer @rasendubi @ejpcmac @Ekleog @GrahamcOfBorg