Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flameshot: 0.5.1 -> 0.6.0 #52163

Merged
merged 1 commit into from Dec 15, 2018
Merged

flameshot: 0.5.1 -> 0.6.0 #52163

merged 1 commit into from Dec 15, 2018

Conversation

timbess
Copy link
Contributor

@timbess timbess commented Dec 15, 2018

Motivation for this change

New version of flameshow is out.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa
Copy link
Member

@GrahamcOfBorg build flameshot

@markuskowa markuskowa merged commit fc1ad44 into NixOS:master Dec 15, 2018
@markuskowa markuskowa mentioned this pull request Dec 15, 2018
Closed
@teto
Copy link
Member

teto commented Jan 18, 2019

does it work for you ? I am on nixos-unstable / i3 and whatever flameshot command I run, it closes immediately with no message/backtrace :s

flameshot --version                                                                                                                                                                                                                                  
Flameshot 
Compiled with Qt 5.12.0

@teto
Copy link
Member

teto commented Jan 18, 2019

nevermind seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@timbess @markuskowa @teto @GrahamcOfBorg @Janik-Haag