Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ola: use python36 #52097

Merged
merged 1 commit into from Dec 15, 2018
Merged

ola: use python36 #52097

merged 1 commit into from Dec 15, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change

python37.pkgs.protobuf does not build with protobuf3_1
Fixes #52090.
A similar thing has been done in #51809.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ola: use python36
5969a54 
python37.pkgs.protobuf does not build with protobuf3_1
@dotlambda dotlambda mentioned this pull request Dec 14, 2018
Closed
@dotlambda dotlambda merged commit d425500 into NixOS:master Dec 15, 2018
@peternewman
Copy link

Just FYI, OLA doesn't currently work with Python 3. We're working on it, and it's got a lot better, but it's not all there yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed build python3.7-protobuf
3 participants
@dotlambda @peternewman @GrahamcOfBorg